Change speed unit abbreviations in SpeedConversion#192
Closed
DerekErb wants to merge 1 commit into
Closed
Conversation
Removed slashes from conversation strings They are unnecessary and were inconsistent (mph but km/h for example)
Contributor
|
Thanks for the contribution! We're going to pass on this one: km/h, m/s, and ft/s are the standard unit symbols (the slash is part of the notation — mph is just the customary exception), so removing the slashes would make the API nonstandard (ms in particular reads as milliseconds) and would break every existing caller. It also leaves the test suite failing, since ConversionsTest::testSpeedConversion calls convertSpeed() with the slashed units. If you'd like to contribute further, fixing the imprecise ft/s factor (1.097 vs the exact 1.09728) with an updated test would be a genuinely useful follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed slashes from conversation strings
They are unnecessary and were inconsistent (mph but km/h for example)