Fixing stock_span_problem.py#10540
Merged
MaximSmolskiy merged 21 commits intoTheAlgorithms:masterfrom Aug 29, 2025
Merged
Conversation
algorithms-keeper
Bot
added
enhancement
for more information, see https://pre-commit.ci
cclauss
reviewed
Oct 15, 2023
| Calculate the span values for a given list of stock prices. | ||
| Args: | ||
| price (list): List of stock prices. | ||
| s (list): List to store the span values. |
Member
There was a problem hiding this comment.
Why are you forcing to caller to allocate this memory? Why not do this in the function?
Contributor
There was a problem hiding this comment.
@AasheeshLikePanner didn't write the code in that way. The code was already like that back when it was first contributed to the repo. The code had the caller allocate the memory because it was directly copied (and thus plagiarized) from the GeeksForGeeks article you linked a few hours ago.
cclauss
reviewed
Oct 15, 2023
…kAndSpan_Doctests # Conflicts: # data_structures/stacks/stock_span_problem.py
for more information, see https://pre-commit.ci
cclauss
reviewed
Oct 15, 2023
cclauss
reviewed
Oct 15, 2023
Co-authored-by: Christian Clauss <cclauss@me.com>
…kAndSpan_Doctests
cclauss
reviewed
Oct 15, 2023
algorithms-keeper
Bot
added
awaiting changes
Co-authored-by: Christian Clauss <cclauss@me.com>
algorithms-keeper
Bot
added
awaiting reviews
algorithms-keeper
Bot
removed
the
tests are failing
…kAndSpan_Doctests # Conflicts: # data_structures/stacks/stock_span_problem.py
MaximSmolskiy
changed the title
algorithms-keeper
Bot
removed
the
tests are failing
MaximSmolskiy
approved these changes
Aug 29, 2025
algorithms-keeper
Bot
removed
the
awaiting reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Adding doctests in stock_span_problem.py
Checklist:
Improve our test coverage #9943