Skip to content

Replace dependency requests with httpx#12742

Closed
lukazlim wants to merge 1 commit intoTheAlgorithms:masterfrom
lukazlim:master
Closed

Replace dependency requests with httpx#12742
lukazlim wants to merge 1 commit intoTheAlgorithms:masterfrom
lukazlim:master

Conversation

@lukazlim
Copy link
Copy Markdown
Contributor

@lukazlim lukazlim commented May 13, 2025

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@lukazlim
Replace dependency requests with httpx
83ccb11 
Signed-off-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>
@lukazlim lukazlim requested a review from cclauss as a code owner May 13, 2025 11:03
@algorithms-keeper
Copy link
Copy Markdown

algorithms-keeper bot commented May 13, 2025

Closing this pull request as invalid

@lukazlim, this pull request is being closed as the files submitted contains an invalid extension. This repository only accepts Python algorithms. Please read the Contributing guidelines first.

Invalid files in this pull request: web_programming/get_imdbtop.py.DISABLED

@algorithms-keeper algorithms-keeper bot removed the request for review from cclauss May 13, 2025 11:03
@algorithms-keeper algorithms-keeper bot added the awaiting reviews This PR is ready to be reviewed label May 13, 2025
@lukazlim lukazlim mentioned this pull request May 13, 2025
Closed
lukazlim added a commit to lukazlim/Python that referenced this pull request May 13, 2025
@lukazlim
Replace dependency requests with httpx
51d1c78 
Fixes TheAlgorithms#12742
Signed-off-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>
@cclauss cclauss mentioned this pull request May 13, 2025
Merged
15 tasks
cclauss pushed a commit to cclauss/Python that referenced this pull request May 13, 2025
@lukazlim @cclauss
Replace dependency requests with httpx
019cc64 
Fixes TheAlgorithms#12742
Signed-off-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>
cclauss pushed a commit to cclauss/Python that referenced this pull request May 13, 2025
@lukazlim @cclauss
Replace dependency requests with httpx
746be9c 
Fixes TheAlgorithms#12742
Signed-off-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>
cclauss pushed a commit to cclauss/Python that referenced this pull request May 13, 2025
@lukazlim @cclauss
Replace dependency requests with httpx
7023df9 
Fixes TheAlgorithms#12742
Signed-off-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>
cclauss added a commit that referenced this pull request May 14, 2025
@cclauss @lukazlim @pre-commit-ci
Lukazlim: Replace dependency requests with httpx (#12744)
a2fa32c 
* Replace dependency `requests` with `httpx`

Fixes #12742
Signed-off-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>

* updating DIRECTORY.md

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>
Co-authored-by: Lim, Lukaz Wei Hwang <lukaz.wei.hwang.lim@intel.com>
Co-authored-by: cclauss <cclauss@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed invalid

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukazlim