Adding doctests to improve Test Coverage for dynamic_programming/fibonacci.py#12831
Closed
Achintya47 wants to merge 6 commits into
Closed
Adding doctests to improve Test Coverage for dynamic_programming/fibonacci.py#12831Achintya47 wants to merge 6 commits into
Achintya47 wants to merge 6 commits into
Conversation
bertrand-awz
suggested changes
Jul 8, 2025
bertrand-awz
left a comment
Contributor
There was a problem hiding this comment.
Suggested changes to pass the checking ruff.
Co-authored-by: Bertrand Awenze <156874668+bertrand-awz@users.noreply.github.com>
Co-authored-by: Bertrand Awenze <156874668+bertrand-awz@users.noreply.github.com>
Author
Thanks a lot for pointing it out , my first PR's so don't really know what ruff's trying to say. Appreciate it! |
bertrand-awz
suggested changes
Jul 12, 2025
| # Extend sequence if needed | ||
| if n >= len(self.sequence): | ||
| difference = n - len(self.sequence) + 1 | ||
| for _ in range(difference): |
Contributor
There was a problem hiding this comment.
This generation is repeated (lines 107–108), I recommend creating a method to generate the sequence.
Co-authored-by: Bertrand Awenze <156874668+bertrand-awz@users.noreply.github.com>
for more information, see https://pre-commit.ci
Member
|
Closing tests_are_failing PRs to prepare for Hacktoberfest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This PR significantly improves the Fibonacci dynamic programming implementation with:
Enhanced Documentation:
Comprehensive Doctests:
Code Improvements:
get_nth()method for single number retrievalreset()method for clearing memoized sequenceTest Coverage:
All doctests have been independently verified for correctness and pass when run locally.
Contributes to #9943
Checklist: