hill_cipher.py: Use int() to gracefully deal with float input#12833
Merged
hill_cipher.py: Use int() to gracefully deal with float input#12833
int() to gracefully deal with float input#12833Conversation
dhruvmanila
approved these changes
Jul 7, 2025
Member
dhruvmanila
left a comment
There was a problem hiding this comment.
This call seems unnecessary because the type of num is annotated as int as discussed previously. I leave this up to you on whether you want to continue with this approach or update the type annotation to reflect the function contract.
Member
Author
|
The Using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Use
int(num)instead ofround(num)to workaroundruff rule ruf057unnecessary-round.Checklist: