Merge branch 'master' into include_uninlined_format_args

Author: siriak

Cargo.toml

@@ -70,7 +70,6 @@ used_underscore_binding = { level = "allow", priority = 1 }
 ref_option = { level = "allow", priority = 1 }
 unnecessary_semicolon = { level = "allow", priority = 1 }
 elidable_lifetime_names = { level = "allow", priority = 1 }
-manual_midpoint = { level = "allow", priority = 1 }
 # restriction-lints:
 absolute_paths = { level = "allow", priority = 1 }
 arithmetic_side_effects = { level = "allow", priority = 1 }
@@ -146,7 +145,6 @@ used_underscore_items = { level = "allow", priority = 1 }
 arbitrary_source_item_ordering = { level = "allow", priority = 1 }
 map_with_unused_argument_over_ranges = { level = "allow", priority = 1 }
 precedence_bits = { level = "allow", priority = 1 }
-string_to_string = { level = "allow", priority = 1 }
 # nursery-lints:
 branches_sharing_code = { level = "allow", priority = 1 }
 cognitive_complexity = { level = "allow", priority = 1 }

src/ciphers/transposition.rs

@@ -161,7 +161,7 @@ fn decrypt(mut msg: String, key_order: Vec<usize>) -> String {
 
     for key in key_order {
         if let Some((_, column)) = indexed_vec.iter().find(|(key_index, _)| key_index == &key) {
-            decrypted_vec.push(column.to_string());
+            decrypted_vec.push(column.clone());
         }
     }
 

src/math/interquartile_range.rs

@@ -13,7 +13,7 @@ pub fn find_median(numbers: &[f64]) -> f64 {
     let mid = length / 2;
 
     if length % 2 == 0 {
-        (numbers[mid - 1] + numbers[mid]) / 2.0
+        f64::midpoint(numbers[mid - 1], numbers[mid])
     } else {
         numbers[mid]
     }

src/math/perfect_square.rs

@@ -18,7 +18,7 @@ pub fn perfect_square_binary_search(n: i32) -> bool {
     let mut right = n;
 
     while left <= right {
-        let mid = (left + right) / 2;
+        let mid = i32::midpoint(left, right);
         let mid_squared = mid * mid;
 
         match mid_squared.cmp(&n) {