Fixed some generator type conversion safety bugs, and upped package versions.

Author: Timovzl

DomainModeling.CodeFixProviders/SyntaxNodeExtensions.cs

@@ -24,8 +24,8 @@ public static SyntaxTrivia GetNewlineTrivia(this SyntaxNode node)
 			var length = trivia.Span.Length;
 			var lengthIsOne = length == 1;
 			var lengthIsTwo = length == 2;
-			nCount += Unsafe.As<bool, int>(ref lengthIsOne);
-			rnCount += Unsafe.As<bool, int>(ref lengthIsTwo);
+			nCount += Unsafe.As<bool, byte>(ref lengthIsOne);
+			rnCount += Unsafe.As<bool, byte>(ref lengthIsTwo);
 		}
 
 		return rnCount > nCount

DomainModeling.Example/Program.cs

@@ -1,9 +1,11 @@
+using System.Diagnostics.CodeAnalysis;
 using Newtonsoft.Json;
 
 namespace Architect.DomainModeling.Example;
 
 public static class Program
 {
+	[UnconditionalSuppressMessage("Trimming", "IL2026:Members annotated with 'RequiresUnreferencedCodeAttribute' require dynamic access otherwise can break functionality when trimming application code", Justification = "Merely demoing JSON serialization.")]
 	public static void Main()
 	{
 		// ValueObject

DomainModeling.Generator/GeneratableExtensions.cs

@@ -9,8 +9,9 @@ internal static class GeneratableExtensions
 	/// </summary>
 	public static bool GetBit(this uint bits, int position)
 	{
-		var result = (bits >> position) & 1U;
-		return Unsafe.As<uint, bool>(ref result);
+		var result = (bits >> position) & 1U;
+		var bitValue = (byte)result;
+		return Unsafe.As<byte, bool>(ref bitValue);
 	}
 
 	/// <summary>
@@ -19,13 +20,16 @@ public static bool GetBit(this uint bits, int position)
 	public static void SetBit(ref this uint bits, int position, bool value)
 	{
 		// Create a mask to unset the target bit: 1 << position
-		// Unset the target bit: & (1 << position)
+		// Unset the target bit: & ~(1 << position)
 
-		// Create a mask to write the target bit value: 1 << value
-		// Write the target bit: | (1 << value)
+		// Create a mask to write the target bit value: value << position
+		// Write the target bit: | (1 << value)
+
+		var intendedBit = Unsafe.As<bool, byte>(ref value);
+		var intendedBitInPosition = (uint)intendedBit << position;
 
 		bits = bits
 			& ~(1U << position)
-			| (Unsafe.As<bool, uint>(ref value) << position);
+			| intendedBitInPosition;
 	}
 }

DomainModeling.Tests/DomainModeling.Tests.csproj

@@ -1,4 +1,4 @@
-<Project Sdk="Microsoft.NET.Sdk">
+<Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
 		<TargetFrameworks>net10.0;net9.0;net8.0</TargetFrameworks>
@@ -23,11 +23,11 @@
 	</PropertyGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.8" />
-		<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.8" />
-		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
+		<PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.14" />
+		<PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="9.0.14" />
+		<PackageReference Include="Microsoft.NET.Test.Sdk" Version="18.3.0" />
 		<PackageReference Include="xunit" Version="2.9.3" />
-		<PackageReference Include="xunit.runner.visualstudio" Version="3.1.4">
+		<PackageReference Include="xunit.runner.visualstudio" Version="3.1.5">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
 		</PackageReference>

DomainModeling/DomainModeling.csproj

@@ -71,7 +71,7 @@ Misc:
 - Feature: Non-generic Wrapper/Identity interfaces.
 - Feature: DummyBuilder records cloned on each step, for reuse.
 - Feature: Analyzer warns when '==' or similar operator implicitly casts some IValueObject to something else. Avoids accidentally comparing unrelated types.
-- Feature: Analyzer warns when '>' or similar operator risks unintended null handling.
+- Feature: Analyzer warns when '>' or similar operator risks unintended null handling.
 - Feature: Analyzer warns if field initializers might be skipped.
 - Fixed: Source-generated default ctor should not exist in case of primary ctor or lacking base default ctor.
 - Fixed: Source-generated records would ignore hand-written ToString()/Equals()/GetHashCode().
@@ -97,7 +97,7 @@ Misc:
 	</ItemGroup>
 
 	<ItemGroup>
-		<PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
+		<PackageReference Include="Newtonsoft.Json" Version="13.0.4" />
 	</ItemGroup>
 
 	<ItemGroup>