Wrappers no longer generated parameterized ctor if any exist.

Author: Timovzl

DomainModeling.Generator/IdentityGenerator.cs

@@ -296,9 +296,7 @@ private static bool FilterSyntaxNode(SyntaxNode node, CancellationToken cancella
 
 			existingComponents |= IdTypeComponents.UnsettableValue.If(members.Any(member => member.Name == "Value" && member is not IFieldSymbol && member is not IPropertySymbol { SetMethod: not null }));
 
-			existingComponents |= IdTypeComponents.Constructor.If(type.InstanceConstructors.Any(ctor =>
-				ctor.Parameters.Length >= 1 && (ctor.Parameters.Length is 1 || ctor.Parameters[1].HasExplicitDefaultValue) && // Callable with exactly 1 parameter
-				ctor.Parameters[0].Type.Equals(underlyingType, SymbolEqualityComparer.Default)));
+			existingComponents |= IdTypeComponents.Constructor.If(type.InstanceConstructors.Any(ctor => ctor is { Parameters.Length: >= 1, DeclaringSyntaxReferences.Length: > 0, }));
 
 			// Records override this, but our implementation is superior
 			existingComponents |= IdTypeComponents.ToStringOverride.If(members.Any(member =>

DomainModeling.Generator/WrapperValueObjectGenerator.cs

@@ -192,9 +192,7 @@ private static bool FilterSyntaxNode(SyntaxNode node, CancellationToken cancella
 
 		existingComponents |= WrapperValueObjectTypeComponents.UnsettableValue.If(members.Any(member => member.Name == "Value" && member is not IFieldSymbol && member is not IPropertySymbol { SetMethod: not null }));
 
-		existingComponents |= WrapperValueObjectTypeComponents.Constructor.If(type.InstanceConstructors.Any(ctor =>
-			ctor.Parameters.Length >= 1 && (ctor.Parameters.Length is 1 || ctor.Parameters[1].HasExplicitDefaultValue) && // Callable with exactly 1 parameter
-			ctor.Parameters[0].Type.Equals(underlyingType, SymbolEqualityComparer.Default)));
+		existingComponents |= WrapperValueObjectTypeComponents.Constructor.If(type.InstanceConstructors.Any(ctor => ctor is { Parameters.Length: >= 1, DeclaringSyntaxReferences.Length: > 0, }));
 
 		existingComponents |= WrapperValueObjectTypeComponents.NullableConstructor.If(underlyingType.IsValueType && type.InstanceConstructors.Any(ctor =>
 			ctor.Parameters.Length == 1 && ctor.Parameters[0].Type.IsNullableOf(underlyingType)));

DomainModeling.Tests/Comparisons/EnumerableComparerTests.cs

@@ -410,7 +410,7 @@ public sealed partial class StringWrapperValueObject : WrapperValueObject<string
 		{
 			protected sealed override StringComparison StringComparison { get; }
 
-			public StringWrapperValueObject(string value, StringComparison stringComparison)
+			public StringWrapperValueObject(string value, StringComparison stringComparison = default)
 			{
 				this.Value = value ?? throw new ArgumentNullException(nameof(value));
 				this.StringComparison = stringComparison.AsDefined();

DomainModeling.Tests/DummyBuilderTests.cs

@@ -136,7 +136,12 @@ public TestEntity()
 		[WrapperValueObject<decimal>]
 		public sealed partial class Amount
 		{
-			// The type's simplest non-default constructor should be used by the builder. It is source-generated.
+			// The type's simplest non-default constructor should be used by the builder
+
+			public Amount(decimal value)
+			{
+				this.Value = value;
+			}
 
 			[Obsolete("Just here to confirm that the generated source code is not invoking it.", error: true)]
 			public Amount(decimal value, string moreComplexConstructor)

DomainModeling.Tests/IdentityTests.cs

@@ -943,6 +943,11 @@ internal partial struct NestedStringId
 		[IdentityValueObject<FormatAndParseTestingIntWrapper>]
 		internal readonly partial struct FormatAndParseTestingIntId
 		{
+			public FormatAndParseTestingIntId(FormatAndParseTestingIntWrapper? value)
+			{
+				this.Value = value;
+			}
+
 			public FormatAndParseTestingIntId(int value)
 			{
 				this.Value = new FormatAndParseTestingIntWrapper(value);
@@ -964,7 +969,7 @@ internal partial struct FormatAndParseTestingUriWrapperId
 		[IdentityValueObject<JsonTestingIntWrapper>]
 		internal readonly partial struct JsonTestingIntId
 		{
-			public JsonTestingIntId(FormatAndParseTestingIntWrapper _)
+			public JsonTestingIntId(JsonTestingIntWrapper? _)
 			{
 				throw new Exception("This constructor should not be used. This lets tests confirm that concerns such as deserialization correctly avoid constructors.");
 			}

DomainModeling/DomainModeling.csproj

@@ -52,10 +52,10 @@ Completed support for nested wrappers:
 - BREAKING: IIdentityConfigurator/IWrapperValueObjectConfigurator now receive additional method type parameter TCore.
 
 Correct string comparisons with EF via ConfigureIdentityConventions()/ConfigureWrapperValueObjectConventions():
-- Feature: These now set a PROVIDER value comparer for each string wrapper property, matching type's case-sensitivity. Since EF Core 7, EF compares keys using provider type instead of model type.
-- Feature: These now warn if a string wrapper property has a collation mismatching the type's case-sensitivity (unless collation is explicit).
+- Feature: These now set PROVIDER value comparer for each string wrapper property, matching type's case-sensitivity. Since EF Core 7, EF compares keys using provider type, not model type.
+- Feature: These now warn if string wrapper property has collation mismatching model's case-sensitivity (unless collation is explicit).
 - Feature: These now accept "options" parameter, which allows specifying collations for case-sensitive vs. ignore-case string wrappers.
-- Feature: ConfigureDomainModelConventions() now has convenience extension methods CustomizeIdentityConventions()/CustomizeWrapperValueObjectConventions(), for easy custom conventions, such as based on core underlying type.
+- Feature: ConfigureDomainModelConventions() now has convenience extensions CustomizeIdentityConventions()/CustomizeWrapperValueObjectConventions(), for easy custom conventions, e.g. based on core underlying type.
 
 Performance:
 - Enhancement: Reduced assembly size: generic JSON serializers instead of generated ones.
@@ -67,6 +67,7 @@ Misc:
 - Semi-breaking: Entity<TId> now has ID-based ==/!=.
 - Semi-breaking: IFormattable & co for string wrappers have stopped treating null strings as "", to better reveal mistakes.
 - Semi-breaking: IIdentity implements IWrapperValueObject.
+- Semi-breaking: Wrappers/Identities generate no parameterized ctor if ANY parameterized exists.
 - Feature: Analyzer and extensions for defined enums.
 - Feature: Non-generic Wrapper/Identity interfaces.
 - Feature: DummyBuilder records cloned on each step, for reuse.
@@ -75,7 +76,7 @@ Misc:
 - Feature: Analyzer warns if field initializers might be skipped.
 - Fixed: Source-generated default ctor should not exist in case of primary ctor or lacking base default ctor.
 - Fixed: Source-generated records would ignore hand-written ToString()/Equals()/GetHashCode().
-- Fixed: Source-generated Wrappers/Identities would not recognize manual member implementations if they were explicit interface implementations.
+- Fixed: Source-generated Wrappers/Identities would not recognize manual explicit interface implementations.
 - Fixed: DummyBuilder generator would struggle with nested types.
 - Fixed: "No source generation on nested type" warning would not show.
 - Fixed: Custom attribute inheritance.