Commonizes IconSet functions#1020
Draft
tomsons26 wants to merge 1 commit into
Draft
Conversation
tomsons26
force-pushed
the
ciconset
branch
6 times, most recently
from
fbecc6f to
6061077
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This turned into a bit of a mess, don't like all those is CC checks or the various system specific magics...
Looking at IconsetClass that was in compat.h, maybe a better way is to create two classes with a singleton static instance, then on game init check a single tile, find out what type it is and use the appropriate class, not sure.
At any rate this still is better as there were unseen direct struct member accesses before.