Skip to content

Commit 8dff9cd

Browse files
committed
Correct DNSSEC proof validity time gap applied to header time
We intended to apply DNSSEC proof validity tests to constrain them to within two hours of the latest block header time, but the code landed with a two minute gap instead. Given DNSSEC proof validity is usually many hours and grace periods are used to ensure records close to expiry aren't used, this is somewhat unlikely to have bitten anyone.
1 parent b98bd95 commit 8dff9cd

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

lightning/src/onion_message/dns_resolution.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -637,7 +637,7 @@ impl OMNameResolver {
637637
// complicated).
638638
// Thus, we have to let the proof times be rather fuzzy.
639639
let max_time_offset =
640-
if cfg!(all(feature = "std", not(fuzzing))) { 0 } else { 60 * 2 };
640+
if cfg!(all(feature = "std", not(fuzzing))) { 0 } else { 60 * 60 * 2 };
641641
if validated_rrs.valid_from > time + max_time_offset {
642642
return None;
643643
}

0 commit comments

Comments
 (0)