First Version Calculator Project

[SylvesterNdwata]

All feedback is welcomed!!

[DSills735]

Hi, @SylvesterNdwata. You have the joy/honor of being my first code review! For that reason, I apologize in advance for the disorganization. Still learning this process.

You did not have anything that blocks approval, but since you have incomplete challenges, I have requested changes.

Thank you!

[DSills735]

🟢 Good things!

Thank you for the effort in this project! I see a strong effort towards the challenges as well. Keep up the good work!

1. Square root and power calculations

2. Reusing previous answer

[DSills735]

🟠 Needs Improvement

1. Y/N validation

The validation for Y or N input isn’t working as intended.
This could lead to incorrect flow or unexpected behavior.
Also, minor formatting issue. Add a space between "?" and "Type" for readability (this specifically is not blocking approval, but it fits here best).
Is the validation case agnostic? Hint: response.Trim().ToLower()?

Suggestion:
Tighten input validation (for example, normalize input and explicitly check valid values) and ensure the loop or branching behaves correctly.

[ ](url)

[DSills735]

1. Trigonometry function input flow (this blocks approval of the challenge.)

Currently skips asking for numbers and immediately redirects.
This breaks expected user flow.

[DSills735]

🟠 Needs Improvement

UI/UX Organization

“Press any key then Enter” effectively requires two key presses.
Not a major issue, but slightly clunky UX. I recognize that this is part of the tutorial. This doesn't require fixing, just note for the future.

Suggestion:
Use Console.ReadKey() instead of ReadLine() for smoother interaction.

3. Console clutter

Output can get messy over time.

Suggestion:
Consider using Console.Clear() at appropriate points to improve readability.

[DSills735]

🟠 Needs Improvement (Blocks approval of challenge)

5. Calculator counter visibility

The counter appears to be implemented, but users can’t see it.

Suggestion:
Display the counter in the UI, for example after each calculation or in a header.

[DSills735]

🟠 Needs Improvement

6. Case-agnostic input for operations

Allowing flexible casing is good, but it may introduce ambiguity or confusion depending on how inputs are handled.

Suggestion:
Consider guiding users with clearer prompts or restricting accepted inputs while still normalizing internally.

[DSills735]

See my comments. Thank you! @ Me when finished. If you don't plan on doing challenges, just remove the trigonometry call so I can pass you.

[DSills735]

Excellent work! Project approved!