Skip to content

Calculator#498

Open
laladrack wants to merge 2 commits into
TheCSharpAcademy:mainfrom
laladrack:main
Open

Calculator#498
laladrack wants to merge 2 commits into
TheCSharpAcademy:mainfrom
laladrack:main

Conversation

@laladrack
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@Dejmenek Dejmenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @laladrack 👋,
I’ve reviewed your project and it works fine, but there’s one thing preventing me from marking it as completed😟. The code logic matches the tutorial, which is great, but the solution should include a solution file and two separate projects: one for Calculator and another for CalculatorLibrary.

For example:
Solution: Calculator.Laladrack.sln
Projects: Calculator.Laladrack.csproj and CalculatorLibrary.Laladrack.csproj

Right now, there is only a single project file😅.
Could you update the project structure so I can proceed with the review😁?

@laladrack
Copy link
Copy Markdown
Author

Heyy! Added a new folder with the calculatorLibrary.csproj :)

Copy link
Copy Markdown

@Dejmenek Dejmenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! 👍

Unfortunately, this still isn't quite what I meant😅.
The project structure doesn't match the one in the Microsoft tutorial yet. You can check the second part of the tutorial here: https://learn.microsoft.com/en-us/visualstudio/get-started/csharp/tutorial-console-part-2?view=visualstudio

Also, you don’t need to include the obj folder in your submission. It contains temporary files that are automatically generated during a build. Since these are recreated on every computer, only your actual source code needs to be submitted, for example:

  • Project files (.csproj)
  • Solution files (.sln, .slnx)
  • Code files (.cs)

Please make sure both projects show up separately in your Solution Explorer (the sidebar on the right) and remove the obj folder. I’ve included an image from the tutorial link above so you can see exactly how it should look😊. Once it looks similar to that, please resubmit for review.
Image

If anything is unclear, feel free to ask! 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants