Skip to content

Enhancements: Auto-start, auto-cred-parsing; Credential parsing fixes#55

Closed
comfy-home wants to merge 4 commits intoTheCarBun:mainfrom
comfy-home:credential-parsing-fixes
Closed

Enhancements: Auto-start, auto-cred-parsing; Credential parsing fixes#55
comfy-home wants to merge 4 commits intoTheCarBun:mainfrom
comfy-home:credential-parsing-fixes

Conversation

@comfy-home
Copy link
Copy Markdown
Contributor

All info in updated README

T

---

* Token parsed automatically, and user name pre-filled.

* add `username = "your-git-username"` to secrets.toml
@TheCarBun
Copy link
Copy Markdown
Owner

I don't wanna be rude but this change isn't needed.
Users are supposed to enter their usernames and api token in the UI itself. That's how the app works.

If you're doing this just to have some experience with open source contribution, check out my other repos and the issues inside them. I've tagged a few issues as good first issue. You can try and fix them if you want.

Thanks for your contribution

@TheCarBun TheCarBun closed this Mar 24, 2026
@comfy-home
Copy link
Copy Markdown
Contributor Author

not rude, but I beg to differ.
Some people wants to track their own progress. It's for them.

I made it purposely switchable, so if anyone wants to track someone else they can.
However, I find it incredibly annoying if I need to enter my own credentials everytime I want to see my own stats.

That's all

@TheCarBun
Copy link
Copy Markdown
Owner

That's a great suggestion but since this is deployed publicly, I don't want to put my username in there as default.
People are free to fork this and deploy their own instance with the changes.

Also, please first create an issue from next time if you have any suggestions or encountered any bugs. It will save a lot of time and effort from both sides.

Thanks again.

@TheCarBun
Copy link
Copy Markdown
Owner

Wait, on second thought, this sounds actually useful.
I'll review this as soon as I'm free

@TheCarBun TheCarBun reopened this Mar 24, 2026
@comfy-home
Copy link
Copy Markdown
Contributor Author

Thanks for the second thought.

I can make it (or you) so the feature might be enabled/disabled via argument.
e.g. you can start with streamlit run app.py --mine which would activate it... or the other way around streamlit run app.py --inspect so "mine" would be the default and --inspect would start "watch someone else" mode.

The version you're hosting can be run via --inspect argument hence there would be no issue whatsoever.

Best

T

@TheCarBun
Copy link
Copy Markdown
Owner

In this case users will have to clone the repo then run it locally to view their stats, right?
Is there anything that would work like localstorage?

everytime a user opens the deployed app, it checks the local storage and shows stats of the last searched username.

I found this in the docs, might help.
https://docs.streamlit.io/develop/api-reference/caching-and-state/st.context

@comfy-home
Copy link
Copy Markdown
Contributor Author

Yes, and yes.

In this case users will have to clone the repo then run it locally to view their stats, right?

That is correct. We'd be able to implement also a version that would work with your hosted version, but it might be a security risk - given end-users have to enter their GitHub token, and the app has access also to private repos... We would not recommend this approach.

"Clone & run" is the safest way:

  • they run it locally → their token is stored on their machine, and never goes to any 3rd party

Viable alternative:

  • I get that cloning is not an easy task to lay-people as clicking on URL, but the app could be compiled (hence end-user's interaction simplified)

Is there anything that would work like localstorage?

Yes, that is totally feasible. If you merge #57 with -- inspect addition and you will run your hosted version with this argument then we can attach caching to it. Should be easy enough.


Let me know if you want me to help you with that. I am using your project as an imaginary "mind-reset" button 😂, every time I run into some complex problem within our main project I go and fix/add something in yours as it's not that complex, and it takes my mind off... It helps 🤷‍♂️
Plus, we've been developing our project only locally for the past ~5 years, so our Git is new, and participating in some open-source projects helps to our brand as well to be honest...

Tom

@TheCarBun
Copy link
Copy Markdown
Owner

I see. You're right, this can be a security issue if saved as cookies or in local storage.
Can we make the hosted version to run with streamlit run app.py no additional argument, then the user's version with an argument.

Haha, glad my repo is helpful for you and good luck on your repo!

@comfy-home comfy-home closed this Apr 5, 2026
@comfy-home
Copy link
Copy Markdown
Contributor Author

CLOSED

REASON: included in (All-In-One) #57 and #59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants