Enhancements: Auto-start, auto-cred-parsing; Credential parsing fixes#55
Enhancements: Auto-start, auto-cred-parsing; Credential parsing fixes#55comfy-home wants to merge 4 commits intoTheCarBun:mainfrom
Conversation
--- * Token parsed automatically, and user name pre-filled. * add `username = "your-git-username"` to secrets.toml
…tate handling in sidebar
|
I don't wanna be rude but this change isn't needed. If you're doing this just to have some experience with open source contribution, check out my other repos and the issues inside them. I've tagged a few issues as Thanks for your contribution |
|
not rude, but I beg to differ. I made it purposely switchable, so if anyone wants to track someone else they can. That's all |
|
That's a great suggestion but since this is deployed publicly, I don't want to put my username in there as default. Also, please first create an issue from next time if you have any suggestions or encountered any bugs. It will save a lot of time and effort from both sides. Thanks again. |
|
Wait, on second thought, this sounds actually useful. |
|
Thanks for the second thought. I can make it (or you) so the feature might be enabled/disabled via argument. The version you're hosting can be run via Best T |
|
In this case users will have to clone the repo then run it locally to view their stats, right? everytime a user opens the deployed app, it checks the local storage and shows stats of the last searched username. I found this in the docs, might help. |
|
Yes, and yes.
That is correct. We'd be able to implement also a version that would work with your hosted version, but it might be a security risk - given end-users have to enter their GitHub token, and the app has access also to private repos... We would not recommend this approach. "Clone & run" is the safest way:
Viable alternative:
Yes, that is totally feasible. If you merge #57 with Let me know if you want me to help you with that. I am using your project as an imaginary "mind-reset" button 😂, every time I run into some complex problem within our main project I go and fix/add something in yours as it's not that complex, and it takes my mind off... It helps 🤷♂️ Tom |
|
I see. You're right, this can be a security issue if saved as cookies or in local storage. Haha, glad my repo is helpful for you and good luck on your repo! |
All info in updated README
T