(all-in-one); latest: Inspect argument for start-up#57
(all-in-one); latest: Inspect argument for start-up#57comfy-home wants to merge 13 commits intoTheCarBun:mainfrom
Conversation
--- * Token parsed automatically, and user name pre-filled. * add `username = "your-git-username"` to secrets.toml
…tate handling in sidebar
Update/readme
Credential parsing fixes
fix: correct contribution count calculation in process_contribution_data
--- start-up commands: `streamlit run app.py` * checks your own stats (backend passes your creds from secrets.toml) `streamlit run app.py -- inspect` * start server in inspect mode, so user can view stats of any GitHub user. It's not auto-opened in default browser `streamlit run app.py --server.headless false -- inspect` * opens dashboard in default browser in inspect mode, so user can view stats of any GitHub user
There was a problem hiding this comment.
wait, I approved this but needed some changes.
when ran with an argument(--inspect in this case) it should open user's own github stats.
running it normally with streamlit run app.py should show the normal deployed version.
There was a problem hiding this comment.
Hey CarBun!
Are you sure you want it that way? I can do it, but TBH, it doesn't make too much sense... let me explain...
If we leave it as is, and -- inspect is used only by your deployed version on git-stats.streamlit.app/ then:
- it's much easier on end-user (no argument needed - only your deployed version needs it)
- end-user can run simply via
streamlit run app.pyand they can view their stats as soon as they visit their frontend, page refresh is working, etc - end user can still view stats of other users if they change name in side-panel
IMO, it's much more user-friendly as it is, and it can be communicated in readme much simpler because:
- if someone clones the repo, I'd say there is 99% chance that they will use it primarily to monitor their progress, not someone elses
- you can just add to readme a line that says "run with
-- inspectif you want to mimic website's behaviour"
Anyways..., I've made that change as a separate PR, so you can choose either this one (#57), or the other one (#59) - you can discard unused one...
Have a great day
T
There was a problem hiding this comment.
Thank you so much for making 2 different prs with alternate changes. I really appreciate it!!
I understand it will be easier for the end user to use it like that but I'm not sure if I'll be able to add an argument during deployment on streamlit cloud.
I don't remember the exact options so I checked the web to see if that's possible but I couldn't find anything about deployment where I can add the start command or any arguments.
There was a problem hiding this comment.
No prob. You're welcome.
Frankly, I thought that this must be the reason. I totally understand - there are several services I used just few times, and when I need to change something within my code once in a while, I'm all anxious because
A) I don't remember the workflow of the service
B) it's several versions ahead now
... so I can relate 👍
There was a problem hiding this comment.
I cannot understand which one to merge for the inspect feature. How do I check?
There was a problem hiding this comment.
- There are currently PR's Update/readme #54, Enhancements: Auto-start, auto-cred-parsing; Credential parsing fixes #55, (all-in-one); latest: Inspect argument for start-up #57, and (all-in-one); latest: Startup argument swap as requested in #57 #59
- You can ignore Update/readme #54 and Enhancements: Auto-start, auto-cred-parsing; Credential parsing fixes #55 (they are both in (all-in-one); latest: Inspect argument for start-up #57/(all-in-one); latest: Startup argument swap as requested in #57 #59)
- Actually, I just closed 54 and 55, so it's not crowded, so forget about them.
- You need to merge the whole (all-in-one); latest: Inspect argument for start-up #57 if you changed your mind/found out how to deploy your hosted version with
-- inspectargument
or
- You need to merge (all-in-one); latest: Startup argument swap as requested in #57 #59 if you want to run your deployed version without argument. Users who will run their own self-hosted version then need to start the server with
streamlit run app.py -- mystats, and of course, fill out their credentials into secrets file.
To sum it up:
- in 57:
- self-hosted version is run via
streamlit run app.py+ credentials in secrets file - your deployed is run via
streamlit run app.py -- inspect
- self-hosted version is run via
- in 59:
- self-hosted version is run via
streamlit run app.py -- mystats+ credentials in secrets file - your deployed version is run via
streamlit run app.py
- self-hosted version is run via
|
*edit: just updated README file ; commit: 4642333 |
2 participants
Here is the whole chunk, also with
-- inspectargument we discussed in #55Supported start-up arguments:
streamlit run app.pystreamlit run app.py -- inspectstreamlit run app.py --server.headless false -- inspect