useEffect with style v1#6
Open
Mustafa88A wants to merge 3 commits into
Open
Conversation
| @@ -0,0 +1,26 @@ | |||
| import { useEffect, useState } from "react"; | |||
| function UseToggle() { | |||
Collaborator
There was a problem hiding this comment.
When you create a react hook, you have to name it correctly, with the use lower-cased.
Additionally, when creating a new hook please make sure you name it carefully.
useToggle is not really a fitting name in this case, because we are not toggling anything.
Instead name it into something like useFetchData or useFetch.
| @@ -0,0 +1,26 @@ | |||
| import { useEffect, useState } from "react"; | |||
| function UseToggle() { | |||
| const [Infor, setInfor] = useState([]); | |||
Collaborator
There was a problem hiding this comment.
When you create a new state, make sure you follow the naming conventions.
the value and setter should be in camel case:
const [infor, setInfor] = useState([]);| const data = await response.json(); | ||
| setInfor(data); | ||
| setIsLoading(false); | ||
| } else console.log("error"); |
Collaborator
There was a problem hiding this comment.
Inside the else clause, you should set isLoading to false, not doing so would make isLoading always true in case an error happens.
if (response.ok) {
const data = await response.json();
setInfor(data);
setIsLoading(false);
} else {
console.log("error");
setIsLoading(false);
}or
if (response.ok) {
const data = await response.json();
setInfor(data);
} else {
console.log("error");
}
setIsLoading(false);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.