Skip to content

Commit 32365dc

Browse files
committed
Improve attribute validation in RangeSlider config
Refactored initConfig to explicitly check for null before validating slider attributes, ensuring default values are only used when attributes are missing. This prevents unintended fallback to defaults when attributes are present but falsy.
1 parent b969be8 commit 32365dc

1 file changed

Lines changed: 10 additions & 11 deletions

File tree

Dist/Functional/RangeSlider.js

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -203,19 +203,18 @@ addStyles() {
203203
* @private
204204
*/
205205
initConfig() {
206-
this.sliderMin =
207-
this.validateNumber(this.slider.getAttribute('wt-rangeslider-min')) || 0;
208-
this.sliderMax =
209-
this.validateNumber(this.slider.getAttribute('wt-rangeslider-max')) ||
210-
100;
211-
this.sliderSteps =
212-
this.validateNumber(this.slider.getAttribute('wt-rangeslider-steps')) ||
213-
1;
206+
const minAttr = this.slider.getAttribute('wt-rangeslider-min');
207+
this.sliderMin = minAttr !== null ? this.validateNumber(minAttr) : 0;
208+
209+
const maxAttr = this.slider.getAttribute('wt-rangeslider-max');
210+
this.sliderMax = maxAttr !== null ? this.validateNumber(maxAttr) : 100;
211+
212+
const stepsAttr = this.slider.getAttribute('wt-rangeslider-steps');
213+
this.sliderSteps = stepsAttr !== null ? this.validateNumber(stepsAttr) : 1;
214214

215215
// Minimum difference between left and right values
216-
this.minDifference =
217-
this.validateNumber(this.slider.getAttribute('wt-rangeslider-mindifference')) ||
218-
this.sliderSteps;
216+
const minDiffAttr = this.slider.getAttribute('wt-rangeslider-mindifference');
217+
this.minDifference = minDiffAttr !== null ? this.validateNumber(minDiffAttr) : this.sliderSteps;
219218

220219
// Show preffix
221220
this.rightSuffix =

0 commit comments

Comments
 (0)