address PR feedback

Author: matthewcsimpson

Dist/WebflowOnly/CMSFilter.js

@@ -63,12 +63,11 @@ class CMSFilter {
     );
     this.emptyMaxCount = 0;
     if (this.emptyElement) {
-      const emptyMaxValue = parseInt(
-        this.emptyElement.getAttribute("wt-cmsfilter-empty-max"),
-        10,
+      const emptyMaxAttr = this.emptyElement.getAttribute(
+        "wt-cmsfilter-empty-max",
       );
-      if (Number.isInteger(emptyMaxValue) && emptyMaxValue >= 0) {
-        this.emptyMaxCount = emptyMaxValue;
+      if (emptyMaxAttr !== null && /^[1-9]\d*$/.test(emptyMaxAttr)) {
+        this.emptyMaxCount = Number(emptyMaxAttr);
       }
     }
     this.resetIx2 =
@@ -446,7 +445,7 @@ class CMSFilter {
             }
           }
         } else {
-          console.error("Failed to fetch HTML from the URL:", link.href);
+          console.error("Failed to fetch HTML from the URL:", link);
         }
       } catch (error) {
         console.error("Error fetching HTML:", error);

__tests__/CMSFilter.test.js

@@ -277,4 +277,67 @@ describe("CMSFilter", () => {
     expect(instance.filteredItems.length).toBe(1);
     expect(instance.emptyElement.style.display).toBe("none");
   });
+
+  test("invalid wt-cmsfilter-empty-max defaults to 0", () => {
+    buildBasicDOM({ emptyMax: "3px" });
+    InitializeCMSFilter();
+    const instance = window.webtricks[0].CMSFilter;
+
+    expect(instance.emptyMaxCount).toBe(0);
+
+    const form = document.querySelector('[wt-cmsfilter-element="filter-form"]');
+    const betaLabel = Array.from(form.querySelectorAll("label")).find((l) =>
+      l.textContent.includes("Beta"),
+    );
+    betaLabel.querySelector("input").checked = true;
+    betaLabel
+      .querySelector("input")
+      .dispatchEvent(new Event("change", { bubbles: true }));
+    instance.ApplyFilters();
+
+    expect(instance.filteredItems.length).toBe(1);
+    expect(instance.emptyElement.style.display).toBe("none");
+  });
+
+  test("negative wt-cmsfilter-empty-max defaults to 0", () => {
+    buildBasicDOM({ emptyMax: "-1" });
+    InitializeCMSFilter();
+    const instance = window.webtricks[0].CMSFilter;
+
+    expect(instance.emptyMaxCount).toBe(0);
+
+    const form = document.querySelector('[wt-cmsfilter-element="filter-form"]');
+    const betaLabel = Array.from(form.querySelectorAll("label")).find((l) =>
+      l.textContent.includes("Beta"),
+    );
+    betaLabel.querySelector("input").checked = true;
+    betaLabel
+      .querySelector("input")
+      .dispatchEvent(new Event("change", { bubbles: true }));
+    instance.ApplyFilters();
+
+    expect(instance.filteredItems.length).toBe(1);
+    expect(instance.emptyElement.style.display).toBe("none");
+  });
+
+  test("non-numeric wt-cmsfilter-empty-max defaults to 0", () => {
+    buildBasicDOM({ emptyMax: "abc" });
+    InitializeCMSFilter();
+    const instance = window.webtricks[0].CMSFilter;
+
+    expect(instance.emptyMaxCount).toBe(0);
+
+    const form = document.querySelector('[wt-cmsfilter-element="filter-form"]');
+    const betaLabel = Array.from(form.querySelectorAll("label")).find((l) =>
+      l.textContent.includes("Beta"),
+    );
+    betaLabel.querySelector("input").checked = true;
+    betaLabel
+      .querySelector("input")
+      .dispatchEvent(new Event("change", { bubbles: true }));
+    instance.ApplyFilters();
+
+    expect(instance.filteredItems.length).toBe(1);
+    expect(instance.emptyElement.style.display).toBe("none");
+  });
 });

docs/WebflowOnly/CMSFilter.md

@@ -54,7 +54,7 @@ Add the script to your Webflow project and include the required attributes on yo
 #### Additional Elements
 - `wt-cmsfilter-element="results-count"` - Shows the number of filtered results
 - `wt-cmsfilter-element="empty"` - Element shown when no results are found
-- `wt-cmsfilter-empty-max="n"` - Optional on the empty element; shows empty block when filtered results are ≤ n (default: 0, so only when zero results; e.g. `wt-cmsfilter-empty-max="3"` shows at 3 or fewer)
+- `wt-cmsfilter-empty-max="n"` - Optional on the empty element; accepts positive whole integers only (`1+`) and shows empty block when filtered results are ≤ n. Missing, `0`, or invalid values default to `0` (show only when there are zero results; e.g. `wt-cmsfilter-empty-max="3"` shows at 3 or fewer). Valid: `1`, `2`, `3`. Invalid: `0`, `3.5`, `3px`, `-1`, `abc`.
 - `wt-cmsfilter-element="clear-all"` - Button to clear all active filters
 - `wt-cmsfilter-element="sort-options"` - Select element for sorting options
 - `wt-cmsfilter-element="tag-template"` - Template for active filter tags