Skip to content

Commit 2a5c889

Browse files
committed
Refactor achievement tab images import
Replaced individual achievement image imports with a grouped import from '@media/Tabs' and updated references throughout the Achievements component for improved maintainability.
1 parent d2528a7 commit 2a5c889

1 file changed

Lines changed: 15 additions & 26 deletions

File tree

src/Components/Achievements/Achievements.tsx

Lines changed: 15 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -2,17 +2,7 @@ import React from 'react';
22
import { Tab, Tabs, TabList, TabPanel } from 'react-tabs';
33
import Food from '../AchieveTabs/Cooking'
44
import Crafting from '../AchieveTabs/Crafting'
5-
import AchCook from '../../Media/Achievements/AchCook.png'
6-
import AchCraft from '../../Media/Achievements/AchCraft.png'
7-
import AchCrops from '../../Media/Achievements/AchCrops.png'
8-
import AchFishing from '../../Media/Achievements/AchFishing.png'
9-
import AchFriendship from '../../Media/Achievements/AchFriendship.png'
10-
import AchGuild from '../../Media/Achievements/AchGuild.png'
11-
import AchItems from '../../Media/Achievements/AchItems.png'
12-
import AchMoney from '../../Media/Achievements/AchMoney.png'
13-
import AchMuseum from '../../Media/Achievements/AchMuseum.png'
14-
import AchQuests from '../../Media/Achievements/AchQuests.png'
15-
import AchGrandpa from '../../Media/Achievements/AchGrandpa.png'
5+
import { TabCook, TabCraft, TabCrops, TabFishing, TabFriendship, TabGuild, TabItems, TabMoney, TabMuseum, TabQuests, TabGrandpa } from '@media/Tabs'
166
import Star from '../../Media/Star.png'
177
import Crops from '../AchieveTabs/Crops';
188
import Fish from '../AchieveTabs/Fish';
@@ -24,28 +14,27 @@ import Collection from '../AchieveTabs/Collection'
2414
import Quests from '../AchieveTabs/quests'
2515

2616
const Achievements = (props) => {
27-
const achievementImg = [
28-
{img: AchCook, alt: "Cooking"},
29-
{img: AchCraft, alt: "Crafting"},
30-
{img: AchCrops, alt: "Crops"},
31-
{img: AchFishing, alt: "Fishing"},
32-
{img: AchFriendship, alt: "Friendship"},
33-
{img: AchGuild, alt: "Guild"},
34-
{img: AchItems, alt: "Items"},
35-
{img: AchMoney, alt: "Money"},
36-
{img: AchMuseum, alt: "Museum"},
37-
{img: AchQuests, alt: "Quests"},
38-
{img: AchGrandpa, alt: "Grandpa's evaluation"}
17+
const TabImg = [
18+
{img: TabCook, alt: "Cooking"},
19+
{img: TabCraft, alt: "Crafting"},
20+
{img: TabCrops, alt: "Crops"},
21+
{img: TabFishing, alt: "Fishing"},
22+
{img: TabFriendship, alt: "Friendship"},
23+
{img: TabGuild, alt: "Guild"},
24+
{img: TabItems, alt: "Items"},
25+
{img: TabMoney, alt: "Money"},
26+
{img: TabMuseum, alt: "Museum"},
27+
{img: TabQuests, alt: "Quests"},
28+
{img: TabGrandpa, alt: "Grandpa's evaluation"}
3929
];
4030

4131
return (
4232
<div className="file-container">
4333
<img className="star" alt="star" src={Star}></img>
4434
<Tabs>
4535
<TabList className="achievement">
46-
{achievementImg.map((img, i) => <Tab key={i}> <img src={img.img} alt={img.alt} title={img.alt} className="tab-ico"></img></Tab>)}
47-
</TabList>
48-
36+
{TabImg.map((img, i) => <Tab key={i}> <img src={img.img} alt={img.alt} title={img.alt} className="tab-ico"></img></Tab>)}
37+
</TabList>
4938
<TabPanel>
5039
<section className="achievement-container">
5140
<Food recipesCooked={props.recipesCooked}></Food>

0 commit comments

Comments
 (0)