Refactor AchieveTabs types and props usage

Updated Collection and Fish components to use imported types from 'types/displayDataTypes' instead of inline interfaces. Simplified Cooking component logic to expect recipesCooked as an array directly, removing nested property access. These changes improve type consistency and simplify prop handling across AchieveTabs components.

Author: JorchCortez

src/Components/AchieveTabs/Collection.tsx

@@ -1,23 +1,11 @@
 import React, { useState, useEffect } from 'react'
+import type { museumCollectionType } from 'types/displayDataTypes';
 
 interface CollectionProps {
-    museumCollection: {
-        artifacts: Array<{
-            found: boolean;
-            inMuseum: boolean;
-            image: string;
-            name: string;
-        }>;
-        minerals: Array<{
-            found: boolean;
-            inMuseum: boolean;
-            image: string;
-            name: string;
-        }>;
-    };
+    museumCollection: museumCollectionType;
 }
 
-const Collection: React.FC<CollectionProps> = ({ museumCollection }) => {
+const Collection = ({ museumCollection }: CollectionProps) => {
     const [totalFound, setTotalFound] = useState(0);
     const [totalDelivered, setTotalDelivered] = useState(0);
     const [total, setTotal] = useState(0);

src/Components/AchieveTabs/Cooking.tsx

@@ -9,17 +9,17 @@ const Food = ( recipesCooked  : dishesCookedType) => {
     const [dishesCooked, setDishesCooked] = useState(0);
     if(!recipesCooked) return <div>No cooking data available.</div>;
 
-    const canMap = (recipesCooked.recipesCooked && recipesCooked.recipesCooked.length > 0);
+    const canMap = (recipesCooked && recipesCooked.length > 0);
     useEffect(() => {  
-        const cookedCount = canMap ? recipesCooked.recipesCooked.map((num) => (num.times !== undefined && num.times > 0) ? 1 : 0).reduce((n: number, next: number) => n + next, 0) : 0;
+        const cookedCount = canMap ? recipesCooked.map((num) => (num.times !== undefined && num.times > 0) ? 1 : 0).reduce((n: number, next: number) => n + next, 0) : 0;
         setDishesCooked(cookedCount);
     }, [recipesCooked]);
-    const cookedCount = canMap ? recipesCooked.recipesCooked.map((num) => (num.times !== undefined && num.times > 0) ? 1 : 0).reduce((n: number, next: number) => n + next, 0) : 0;
-    const knownCount = canMap ? recipesCooked.recipesCooked.map((num) => (num.times !== undefined && num.times >= 0) ? 1 : 0).reduce((n: number, next: number) => n + next, 0) : 0;
+    const cookedCount = canMap ? recipesCooked.map((num) => (num.times !== undefined && num.times > 0) ? 1 : 0).reduce((n: number, next: number) => n + next, 0) : 0;
+    const knownCount = canMap ? recipesCooked.map((num) => (num.times !== undefined && num.times >= 0) ? 1 : 0).reduce((n: number, next: number) => n + next, 0) : 0;
 
     return ( 
         <div className="progress-container">   
-            <span className="a-title"><h1>You have cooked {cookedCount}, knowing {knownCount} out of {recipesCooked.recipesCooked.length} recipes</h1></span>
+            <span className="a-title"><h1>You have cooked {cookedCount}, knowing {knownCount} out of {recipesCooked.length} recipes</h1></span>
             <br />
             <h2>Cooking Achievements</h2>
             <ul className="a-List"> 

src/Components/AchieveTabs/Fish.tsx

@@ -1,19 +1,14 @@
 import React, { useState, useEffect } from 'react'
-
-interface FishItem {
-    fished: boolean;
-    image: string;
-    name: string;
-}
+import type { generalFormatedItemType } from 'types/displayDataTypes';
 
 interface FishProps {
-    fishCaught: FishItem[];
+    fishCaught: generalFormatedItemType[];
 }
 
-const Fish: React.FC<FishProps> = ({ fishCaught }) => {
+const Fish = ({ fishCaught }: FishProps) => {
     const [totalFished, setTotalFished] = useState(0);
 
-    const getCraftedItems = (items: FishItem[]) => {
+    const getCraftedItems = (items: generalFormatedItemType[]) => {
         return items.map((num) => (num.fished) ? 1 : 0).reduce((n: number, next: number) => next + n, 0);
     };