Use TIMING_* enums for next-map timing

Switch timing handling to use the TIMING_* enum (0=NextMap, 1=NextRound, 2=Instant). Updated API docs, command validation/error text, native input bounds checks, and callsites to stop using 1..3 and iTiming-1 adjustments. Affected files: include/multimode.inc (doc comment), multimode_adminmenu.sp (menu mapping), multimode_core.sp (native validation and ExecuteModeChange call), and multimode_randomcycle.sp (use TIMING_NEXTMAP constant). This unifies timing semantics and avoids off-by-one conversions.

Author: TheDGB

addons/sourcemod/scripting/include/multimode.inc

@@ -156,7 +156,7 @@ native bool MultiMode_GetCurrentVoteId(char[] buffer, int maxlen);
  * Sets the next map (equivalent to multimode_setnextmap command).
  * 
  * @param map           Map name to set as next map.
- * @param timing        Timing mode: 1 = Next Map, 2 = Next Round, 3 = Instant.
+ * @param timing        Timing mode: 0 = Next Map, 1 = Next Round, 2 = Instant (see TimingMode enum).
  * @param gamemode      Gamemode name (optional, empty string to auto-detect).
  * @param subgroup      Subgroup name (optional, empty string if not specified).
  * @return              True on success, false on failure.

addons/sourcemod/scripting/multimode_adminmenu.sp

@@ -1030,11 +1030,11 @@ public int ForceTimingMenuHandler(Menu menu, MenuAction action, int client, int
         char timingStr[16];
         menu.GetItem(param2, timingStr, sizeof(timingStr));
 
-        int timing = 1;
+        int timing = TIMING_NEXTMAP;
         if (StrEqual(timingStr, "nextround"))
-            timing = 2;
+            timing = TIMING_NEXTROUND;
         else if (StrEqual(timingStr, "instant"))
-            timing = 3;
+            timing = TIMING_INSTANT;
 
         ExecuteModeChange(
             g_sClientPendingGameMode[client],

addons/sourcemod/scripting/multimode_core.sp

@@ -2693,11 +2693,11 @@ public int NativeMMC_SetNextMap(Handle plugin, int numParams)
     }
 
     int iTiming = GetNativeCell(2);
-    if (iTiming < 1 || iTiming > 3)
+    if (iTiming < view_as<int>(TIMING_NEXTMAP) || iTiming > view_as<int>(TIMING_INSTANT))
     {
         return false;
     }
-    
+
     char sGroup[64];
     char sSubGroup[64];
     GetNativeString(3, sGroup, sizeof(sGroup));
@@ -2773,7 +2773,7 @@ public int NativeMMC_SetNextMap(Handle plugin, int numParams)
         }
     }
 
-    ExecuteModeChange(sGroup, sMap, iTiming - 1, sSubGroup);
+    ExecuteModeChange(sGroup, sMap, iTiming, sSubGroup);
     return true;
 }
 
@@ -3419,9 +3419,9 @@ public Action Command_SetNextMap(int client, int args)
     GetCmdArg(2, sTiming, sizeof(sTiming));
     int iTiming = StringToInt(sTiming);
 
-    if (iTiming < 1 || iTiming > 3)
+    if (iTiming < view_as<int>(TIMING_NEXTMAP) || iTiming > view_as<int>(TIMING_INSTANT))
     {
-        ReplyToCommand(client, "[MultiMode] Error: Invalid timing. Use 1, 2 ou 3.");
+        ReplyToCommand(client, "[MultiMode] Error: Invalid timing. Use 0 (NextMap), 1 (NextRound) or 2 (Instant).");
         return Plugin_Handled;
     }
 
@@ -3514,7 +3514,7 @@ public Action Command_SetNextMap(int client, int args)
     }
 
     ReplyToCommand(client, "[MultiMode] Setting next map to '%s' (Group: %s, Subgroup: %s).", sMap, sGroup, strlen(sSubGroup) > 0 ? sSubGroup : "NoN");
-    ExecuteModeChange(sGroup, sMap, iTiming - 1, sSubGroup);
+    ExecuteModeChange(sGroup, sMap, iTiming, sSubGroup);
 
     return Plugin_Handled;
 }

addons/sourcemod/scripting/multimode_randomcycle.sp

@@ -191,15 +191,15 @@ void SelectRandomNextMap(bool bSetNextMap = false)
             {
                 if (strlen(selectedSubgroup) > 0 && strlen(selectedGroup) > 0)
                 {
-                    MultiMode_SetNextMap(selectedMap, 1, selectedGroup, selectedSubgroup);
+                    MultiMode_SetNextMap(selectedMap, TIMING_NEXTMAP, selectedGroup, selectedSubgroup);
                 }
                 else if (strlen(selectedGroup) > 0)
                 {
-                    MultiMode_SetNextMap(selectedMap, 1, selectedGroup);
+                    MultiMode_SetNextMap(selectedMap, TIMING_NEXTMAP, selectedGroup);
                 }
                 else
                 {
-                    MultiMode_SetNextMap(selectedMap, 1);
+                    MultiMode_SetNextMap(selectedMap, TIMING_NEXTMAP);
                 }
 
                 DataPack pack = new DataPack();