Make BigInt modmail work with sqlite

Author: bristermitten

src/modules/core/bump.listener.ts

@@ -86,7 +86,8 @@ export async function handleBumpStreak(
 	// time since last bump
 	if (lastBumpNotificationTime.getTime() !== 0) {
 		const timeSinceLastBump = Date.now() - lastBumpNotificationTime.getTime();
-		if (timeSinceLastBump < 300000) { // this might seem generous, but in reality when you factor in the discord delay, even if you react instantaneously on your screen you can still be too slow
+		if (timeSinceLastBump < 300000) {
+			// this might seem generous, but in reality when you factor in the discord delay, even if you react instantaneously on your screen you can still be too slow
 			message.channel.send(
 				`⚡⚡⚡ ${fakeMention(interactionOld.user)} bumped in just **${timeSinceLastBump / 1000}s**!`,
 			);

src/modules/modmail/modmail.listener.ts

@@ -307,7 +307,7 @@ const handleModmailAssignSelect = async (
 		}
 		const modMail = await ModMailTicket.findOne({
 			where: {
-				id: BigInt(ticketId),
+				id: ticketId,
 			},
 		});
 
@@ -431,6 +431,11 @@ const handleModmailSubmit = async (
 			type: ChannelType.PublicThread,
 		});
 		if (!thread.joined) await thread.join();
+		logger.debug(
+			"Created modmail thread for user %s with id %s",
+			interaction.user.id,
+			thread.id,
+		);
 
 		const ticket = await createModMailTicket(
 			BigInt(userId),

src/store/RealBigInt.ts

@@ -1,10 +1,29 @@
 import { DataTypes, ValidationErrorItem } from "@sequelize/core";
 
+/**
+ * A better bigint type than the one Sequelize provides
+ * It uses a native bigint where supported, otherwise it converts it to a string adding the suffix "n" to prevent
+ * the driver parsing as a number
+ */
 export class RealBigInt extends DataTypes.ABSTRACT<bigint> {
 	toSql() {
-		return "BIGINT";
-		// this is actually kind of bad, as it will use BIGINT on sqlite too, potentially losing data
-		// however since sqlite is only used for testing i basically don't care
+		if (this.nativeBigIntSupport()) {
+			return "BIGINT";
+		} else {
+			return "STRING";
+		}
+	}
+
+	nativeBigIntSupport() {
+		return this._getDialect().supports.dataTypes.BIGINT;
+	}
+
+	override toBindableValue(value: bigint): unknown {
+		if (this.nativeBigIntSupport()) {
+			return value;
+		} else {
+			return `${value.toString()}n`;
+		}
 	}
 
 	override sanitize(value: unknown): unknown {
@@ -29,7 +48,13 @@ export class RealBigInt extends DataTypes.ABSTRACT<bigint> {
 
 	override parseDatabaseValue(value: unknown) {
 		if (typeof value === "bigint") return value;
-		if (typeof value === "string") return BigInt(value);
+		if (typeof value === "string") {
+			// stupid lol
+			if (value.endsWith("n")) {
+				return BigInt(value.slice(0, -1));
+			}
+			return BigInt(value);
+		}
 		if (typeof value === "number") return BigInt(value);
 		if (typeof value === "boolean") return BigInt(value);
 

src/store/models/FAQ.ts

@@ -20,10 +20,10 @@ export class FAQ extends Model<
 	InferAttributes<FAQ>,
 	InferCreationAttributes<FAQ>
 > {
-	@Attribute(RealBigInt)
+	@Attribute(DataTypes.INTEGER)
 	@PrimaryKey
 	@AutoIncrement
-	public declare id: CreationOptional<bigint>;
+	public declare id: CreationOptional<number>;
 
 	@Attribute(RealBigInt)
 	@NotNull

src/store/models/ModMailTicket.ts

@@ -8,7 +8,6 @@ import {
 import {
 	AllowNull,
 	Attribute,
-	AutoIncrement,
 	Default,
 	NotNull,
 	PrimaryKey,
@@ -35,10 +34,9 @@ export class ModMailTicket extends Model<
 	InferAttributes<ModMailTicket>,
 	InferCreationAttributes<ModMailTicket>
 > {
-	@Attribute(RealBigInt)
+	@Attribute(DataTypes.INTEGER)
 	@PrimaryKey
-	@AutoIncrement
-	public declare id: CreationOptional<bigint>;
+	public declare id: CreationOptional<number>;
 
 	@Attribute(RealBigInt)
 	@NotNull

src/store/models/ModeratorActions.ts

@@ -8,7 +8,6 @@ import {
 import {
 	AllowNull,
 	Attribute,
-	AutoIncrement,
 	BelongsTo,
 	ColumnName,
 	Default,
@@ -28,10 +27,9 @@ export class ModeratorActions extends Model<
 	InferAttributes<ModeratorActions>,
 	InferCreationAttributes<ModeratorActions>
 > {
-	@Attribute(RealBigInt)
+	@Attribute(DataTypes.INTEGER)
 	@PrimaryKey
-	@AutoIncrement
-	public declare id: CreationOptional<bigint>;
+	public declare id: CreationOptional<number>;
 
 	@Attribute(RealBigInt)
 	@NotNull