fixed the chains usage in ParticlesMC#77
Merged
Conversation
V-Francois
approved these changes
May 22, 2026
Contributor
V-Francois
left a comment
V-Francois
left a comment
There was a problem hiding this comment.
LGTM, just a couple suggestions about formatting
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Member
|
Great, thanks a lot @cyfraysse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The chains load was broken. This fix allows using a configuration directory to handle multiple initial conditions.
This requires adding a
filename = "init"entry to the TOML file if a directory is used.(Maybe adding a section to describe the usage of multiple chains in the README could be a good idea later on).
I have verified that it still supports a single configuration file as input.