Add baseConfig fallback to readConfig and unit tests for configuration merge scenarios

Author: andrey-helldar

dist/index.js

@@ -34560,13 +34560,14 @@ const writeFile = (config, filename, content) => {
     fs.writeFileSync(filePath(config, filename), content);
 };
 exports.writeFile = writeFile;
-const readConfig = (config, userConfigPath) => {
-    const content = (0, exports.readFile)(config_1.defaultConfig, userConfigPath);
+const readConfig = (override, userConfigPath, baseConfig = undefined) => {
+    const dataConfig = baseConfig ?? config_1.defaultConfig;
+    const content = (0, exports.readFile)(dataConfig, userConfigPath);
     if (content === '') {
-        return (0, deepmerge_ts_1.deepmerge)(config_1.defaultConfig, config);
+        return (0, deepmerge_ts_1.deepmerge)(dataConfig, override);
     }
     const userConfig = yaml.load(content);
-    return (0, deepmerge_ts_1.deepmerge)(config_1.defaultConfig, config, userConfig);
+    return (0, deepmerge_ts_1.deepmerge)(dataConfig, override, userConfig);
 };
 exports.readConfig = readConfig;
 const exec = async (command) => {

src/utils/filesystem.ts

@@ -31,16 +31,18 @@ export const writeFile = (config: Config, filename: string, content: string): vo
     fs.writeFileSync(filePath(config, filename), content)
 }
 
-export const readConfig = (config: Config, userConfigPath: string): Config => {
-    const content = readFile(defaultConfig, userConfigPath)
+export const readConfig = (override: Config, userConfigPath: string, baseConfig: Config | undefined = undefined): Config => {
+    const dataConfig: Config = baseConfig ?? defaultConfig
+
+    const content: string = readFile(dataConfig, userConfigPath)
 
     if (content === '') {
-        return <Config>deepmerge(defaultConfig, config)
+        return <Config>deepmerge(dataConfig, override)
     }
 
     const userConfig = <Config>yaml.load(content)
 
-    return <Config>deepmerge(defaultConfig, config, userConfig)
+    return <Config>deepmerge(dataConfig, override, userConfig)
 }
 
 export const exec = async (command: string): Promise<string> => {

tests/unit/filesystem.test.ts

@@ -0,0 +1,20 @@
+import { testConfig } from '../helpers/config'
+import { Config, defaultConfig } from '../../src/types/config'
+import { readConfig } from '../../src/utils/filesystem'
+import { CONFIG_PATH } from '../../src/utils/inputs'
+
+test('read config', () => {
+    const data: Config = readConfig(testConfig, CONFIG_PATH.defaultValue, testConfig)
+
+    expect(data.directory).toBe(testConfig.directory)
+    expect(data.image.parameters.packageName).toBe(testConfig.image.parameters.packageName)
+    expect(data.image.parameters.title).toBe(testConfig.image.parameters.title)
+    expect(data.image.parameters.description).toBe(testConfig.image.parameters.description)
+
+    expect(data.path.readme).toBe(defaultConfig.path.readme)
+    expect(data.image.url).toBe(defaultConfig.image.url)
+    expect(data.image.parameters.pattern).toBe(defaultConfig.image.parameters.pattern)
+
+    expect(data.image.parameters.packageManager).toBe('none')
+    expect(data.image.parameters.icon).toBe('photograph')
+})