Refactors subject disposal

michaelstonis · michaelstonis · commit 0726df29d64c · 2025-07-17T16:20:28.000-05:00
Removes unnecessary disposal of lifecycle and navigation event subjects.

The `DisposeWith` call was causing issues with subject lifetimes,
leading to unexpected behavior. Removing it allows subjects to
properly complete and prevents premature disposal.
diff --git a/Stellar/ViewManager.cs b/Stellar/ViewManager.cs
@@ -58,8 +58,8 @@ public ViewManager()
     {
         _controlBindings = new(this);
 
-        _lifecycleEvents = new(() => new Subject<LifecycleEvent>().DisposeWith(_controlBindings), LazyThreadSafetyMode.ExecutionAndPublication);
-        _navigationEvents = new(() => new Subject<NavigationEvent>().DisposeWith(_controlBindings), LazyThreadSafetyMode.ExecutionAndPublication);
+        _lifecycleEvents = new(() => new Subject<LifecycleEvent>(), LazyThreadSafetyMode.ExecutionAndPublication);
+        _navigationEvents = new(() => new Subject<NavigationEvent>(), LazyThreadSafetyMode.ExecutionAndPublication);
     }
 
     public void Dispose()

Original file line number	Diff line number	Diff line change
`@@ -58,8 +58,8 @@ public ViewManager()`
`58`	`58`	`{`
`59`	`59`	`_controlBindings = new(this);`
`60`	`60`
`61`		`- _lifecycleEvents = new(() => new Subject<LifecycleEvent>().DisposeWith(_controlBindings), LazyThreadSafetyMode.ExecutionAndPublication);`
`62`		`- _navigationEvents = new(() => new Subject<NavigationEvent>().DisposeWith(_controlBindings), LazyThreadSafetyMode.ExecutionAndPublication);`
	`61`	`+ _lifecycleEvents = new(() => new Subject<LifecycleEvent>(), LazyThreadSafetyMode.ExecutionAndPublication);`
	`62`	`+ _navigationEvents = new(() => new Subject<NavigationEvent>(), LazyThreadSafetyMode.ExecutionAndPublication);`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`public void Dispose()`