Small fixes for RES upcoming changes, zero impact otherwise#36
Open
corylulu wants to merge 1 commit into
Open
Conversation
The current source build adds a "multi-count" counter (counts how many multi's the subreddit is in) as a span inside the subscriber button span. So updating the `.subButtons span:not(.subscribe-button)` to `.subButtons > span:not(.subscribe-button)` should address any future issues of nested spans becoming buttons while also just hiding the "multi-count" all together since it's fairly useless anyways.
Owner
|
I'm not comfortable completely hiding a feature users may be using. I know it's screwing up the sidebar (it is for most subreddits) and RES doesn't have a way to disable it, but I'd like to wait a bit longer. |
Contributor
Author
|
Yeah, if it does get pushed though, there isn't gonna be a decent way to keep all those buttons on the same line though without shrinking the text further and killing the symmetry. Might just wanna make it 2 lines at that point. What bothers me is it doesn't actually add anything meaningful. Hovering over the sub button tells you what multi's it's in. All this does is provide a counter, as if you need that every time you view the subreddit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current source build adds a "multi-count" counter (counts how many multi's the subreddit is in) as a span inside the subscriber button span. So updating the
.subButtons span:not(.subscribe-button)to.subButtons > span:not(.subscribe-button)should address any future issues of nested spans becoming buttons while also just hiding the "multi-count" all together since it's fairly useless anyways.