Skip to content

Small fixes for RES upcoming changes, zero impact otherwise#36

Open
corylulu wants to merge 1 commit into
TheEnigmaBlade:masterfrom
corylulu:patch-4
Open

Small fixes for RES upcoming changes, zero impact otherwise#36
corylulu wants to merge 1 commit into
TheEnigmaBlade:masterfrom
corylulu:patch-4

Conversation

@corylulu

@corylulu corylulu commented Dec 2, 2016

Copy link
Copy Markdown
Contributor

The current source build adds a "multi-count" counter (counts how many multi's the subreddit is in) as a span inside the subscriber button span. So updating the .subButtons span:not(.subscribe-button) to .subButtons > span:not(.subscribe-button) should address any future issues of nested spans becoming buttons while also just hiding the "multi-count" all together since it's fairly useless anyways.

The current source build adds a "multi-count" counter (counts how many multi's the subreddit is in) as a span inside the subscriber button span. So updating the `.subButtons span:not(.subscribe-button)` to `.subButtons > span:not(.subscribe-button)` should address any future issues of nested spans becoming buttons while also just hiding the "multi-count" all together since it's fairly useless anyways.
@TheEnigmaBlade

Copy link
Copy Markdown
Owner

I'm not comfortable completely hiding a feature users may be using. I know it's screwing up the sidebar (it is for most subreddits) and RES doesn't have a way to disable it, but I'd like to wait a bit longer.

@corylulu

corylulu commented Dec 5, 2016

Copy link
Copy Markdown
Contributor Author

Yeah, if it does get pushed though, there isn't gonna be a decent way to keep all those buttons on the same line though without shrinking the text further and killing the symmetry. Might just wanna make it 2 lines at that point. What bothers me is it doesn't actually add anything meaningful. Hovering over the sub button tells you what multi's it's in. All this does is provide a counter, as if you need that every time you view the subreddit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants