Fix for camera pitch clamping (software renderer)#599
Merged
Conversation
If an angle between 180 and 360 degrees is passed in, convert it to negative by subtracting 360 This will not fix values that are > 540 and < 180 but I think it is fair to assume that such values won't be encountered in practice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug associated with #468
where I clamped the camera's pitch for the software renderer, but did not account for situations where pitch is expressed as a value between 180 and 360.
Angles between 180 and 360 need to first be converted to a value between -180 and 0, by subtracting 360
(This will not fix values that are > 540 and < 180 but I think it is fair to assume that such values won't be encountered in practice. This issue only occurred when transforming the camera object with a VUE, where all pitch values will be between 0 and 360)