Add isSigned32 helper

Author: TheKodeToad

backend/src/common/general.ts

@@ -16,6 +16,11 @@ export function todo(): never {
 	throw new Error("Function not implemented");
 }
 
+/** @return true is the number is a valid 32-bit signed integer */
+export function isSigned32(number: number): boolean {
+	return number < 2 ** 31 && number >= -(2 ** 31);
+}
+
 export type ValuesOf<T> = T[keyof T];
 export type Awaitable<T> = T | PromiseLike<T>;
 export type Nullable<T> = {

backend/src/plugins/moderation/storage/cases.ts

@@ -1,3 +1,4 @@
+import { isSigned32 } from "#common/general.ts";
 import { poolTransaction } from "#common/pg/transaction.ts";
 import { dbParse } from "#storage/storage.ts";
 import type { Pool } from "pg";
@@ -35,7 +36,7 @@ export namespace casesTable {
 		guildID: string,
 		number: number,
 	): Promise<CaseInfo | null> {
-		if (number < 0 || number >= 2 ** 32) {
+		if (!isSigned32(number)) {
 			return null;
 		}
 
@@ -222,7 +223,7 @@ export namespace casesTable {
 		guildID: string,
 		number: number,
 	): Promise<boolean> {
-		if (number < 0 || number >= 2 ** 32) {
+		if (!isSigned32(number)) {
 			return false;
 		}
 

backend/src/plugins/reminders/storage/reminders.ts

@@ -1,3 +1,4 @@
+import { isSigned32 } from "#common/general.ts";
 import { poolTransaction } from "#common/pg/transaction.ts";
 import { dbParse } from "#storage/storage.ts";
 import { ChannelTypes } from "oceanic.js";
@@ -27,7 +28,7 @@ export namespace remindersTable {
 		guildID: string,
 		number: number,
 	): Promise<Reminder | null> {
-		if (number < 0 || number >= 2 ** 32) {
+		if (!isSigned32(number)) {
 			return null;
 		}
 
@@ -163,7 +164,7 @@ export namespace remindersTable {
 		guildID: string,
 		number: number,
 	): Promise<boolean> {
-		if (number < 0 || number >= 2 ** 32) {
+		if (!isSigned32(number)) {
 			return false;
 		}
 
@@ -184,7 +185,7 @@ export namespace remindersTable {
 		number: number,
 		ownerID: string,
 	): Promise<boolean> {
-		if (number < 0 || number >= 2 ** 32) {
+		if (!isSigned32(number)) {
 			return false;
 		}