Create constants files to make them easier to find (and fix an error)

Author: TheKodeToad

backend/src/plugin/core/commandEngine/handler/componentHandler.ts

@@ -2,10 +2,10 @@ import { moduleLogger } from "#common/logger/index.ts";
 import { TTLMap } from "#common/ttlMap.ts";
 import type { SquirrelDiscordContext } from "#discord/index.ts";
 import {
-	AUTO_DEFER_AFTER,
-	STATE_CLEANUP_INTERVAL,
-	STATE_EXPIRE_AFTER,
-} from "#plugin/core/commandEngine/index.ts";
+	COMMAND_AUTO_DEFER_AFTER,
+	COMMAND_STATE_CLEANUP_INTERVAL,
+	COMMAND_STATE_EXPIRE_AFTER,
+} from "#plugin/core/constants.ts";
 import { transformReply } from "#plugin/core/helper/commands.ts";
 import type {
 	ComponentContext,
@@ -35,9 +35,12 @@ interface ComponentHandler {
 const logger = moduleLogger();
 
 const activeHandlers: TTLMap<string, ComponentHandler> = new TTLMap(
-	STATE_EXPIRE_AFTER,
+	COMMAND_STATE_EXPIRE_AFTER,
 );
-setInterval(() => activeHandlers.cleanup(), STATE_CLEANUP_INTERVAL).unref();
+setInterval(
+	() => activeHandlers.cleanup(),
+	COMMAND_STATE_CLEANUP_INTERVAL,
+).unref();
 
 export default [onBotEvent({ type: "interactionCreate", listener: handle })];
 
@@ -158,7 +161,7 @@ class ComponentContextImpl implements ComponentContext {
 			},
 			Math.max(
 				0,
-				AUTO_DEFER_AFTER -
+				COMMAND_AUTO_DEFER_AFTER -
 					(Date.now() - interaction.createdAt.getTime()),
 			),
 		).unref();

backend/src/plugin/core/commandEngine/handler/prefixHandler.ts

@@ -9,16 +9,16 @@ import {
 	listenForInteractions,
 	unlistenForInteractions,
 } from "#plugin/core/commandEngine/handler/componentHandler.ts";
-import {
-	STATE_CLEANUP_INTERVAL,
-	STATE_EXPIRE_AFTER,
-} from "#plugin/core/commandEngine/index.ts";
 import { formatArgsParseError } from "#plugin/core/commandEngine/parsing/index.ts";
 import {
 	readPrefixArgs,
 	readPrefixName,
 } from "#plugin/core/commandEngine/parsing/prefixParser.ts";
 import { StringReader } from "#plugin/core/commandEngine/parsing/stringReader.ts";
+import {
+	COMMAND_STATE_CLEANUP_INTERVAL,
+	COMMAND_STATE_EXPIRE_AFTER,
+} from "#plugin/core/constants.ts";
 import { transformReply } from "#plugin/core/helper/commands.ts";
 import { coreConfigStore } from "#plugin/core/index.ts";
 import type {
@@ -57,8 +57,13 @@ export default [
 // if anything is added here, make sure the message type can be replied to
 const ALLOWED_MESSAGE_TYPES = [MessageTypes.DEFAULT, MessageTypes.REPLY];
 
-const trackedMessages: TTLMap<string, Message> = new TTLMap(STATE_EXPIRE_AFTER);
-setInterval(() => trackedMessages.cleanup(), STATE_CLEANUP_INTERVAL).unref();
+const trackedMessages: TTLMap<string, Message> = new TTLMap(
+	COMMAND_STATE_EXPIRE_AFTER,
+);
+setInterval(
+	() => trackedMessages.cleanup(),
+	COMMAND_STATE_CLEANUP_INTERVAL,
+).unref();
 
 async function handle(
 	squirrelCtx: SquirrelDiscordContext,

backend/src/plugin/core/commandEngine/handler/slashHandler.ts

@@ -13,9 +13,9 @@ import {
 	listenForInteractions,
 	unlistenForInteractions,
 } from "#plugin/core/commandEngine/handler/componentHandler.ts";
-import { AUTO_DEFER_AFTER } from "#plugin/core/commandEngine/index.ts";
 import { formatArgsParseError } from "#plugin/core/commandEngine/parsing/index.ts";
 import { readSlashArgs } from "#plugin/core/commandEngine/parsing/slashParser.ts";
+import { COMMAND_AUTO_DEFER_AFTER } from "#plugin/core/constants.ts";
 import { safePreRun, transformReply } from "#plugin/core/helper/commands.ts";
 import { coreConfigStore } from "#plugin/core/index.ts";
 import {
@@ -333,7 +333,7 @@ class SlashContext implements CommandContext {
 			},
 			Math.max(
 				0,
-				AUTO_DEFER_AFTER -
+				COMMAND_AUTO_DEFER_AFTER -
 					(Date.now() - interaction.createdAt.getTime()),
 			),
 		).unref();

…d/src/plugin/core/commandEngine/index.ts backend/src/plugin/core/constants.tsbackend/src/plugin/core/commandEngine/index.ts renamed to backend/src/plugin/core/constants.ts backend/src/plugin/core/commandEngine/index.ts renamed to backend/src/plugin/core/constants.ts

@@ -1,10 +1,10 @@
 /**
  * How long to expire command state (edit tracking + component listening)
  */
-export const STATE_EXPIRE_AFTER = 1000 * 60 * 30;
-export const STATE_CLEANUP_INTERVAL = 1000 * 60;
+export const COMMAND_STATE_EXPIRE_AFTER = 1000 * 60 * 30;
+export const COMMAND_STATE_CLEANUP_INTERVAL = 1000 * 60;
 /**
  * Interactions are deferred if the command is taking some time to finish rather than relying on the author of the command to remember to defer it manually
  * (this should also improve latency - in the best case only one api call is being sent back to Discord)
  */
-export const AUTO_DEFER_AFTER = 1000;
+export const COMMAND_AUTO_DEFER_AFTER = 1000;

backend/src/plugin/logging/constants.ts

@@ -0,0 +1,4 @@
+import { HOUR, MINUTE } from "#common/time.ts";
+
+export const MESSAGE_CLEANUP_INTERVAL = 30 * MINUTE;
+export const MESSAGE_CLEANUP_THRESHOLD = 6 * HOUR;

backend/src/plugin/logging/logger/messages.ts

@@ -1,10 +1,13 @@
 import { getDefaultAvatarURL } from "#common/discord/urls.ts";
 import { moduleLogger } from "#common/logger/index.ts";
 import { makeMemberUserView, makeUserView } from "#common/template/user.ts";
-import { HOUR, MINUTE } from "#common/time.ts";
 import { onBotInit } from "#discord/extensionPoints.ts";
 import type { SquirrelDiscordContext } from "#discord/index.ts";
 import { onBotEvent } from "#plugin/core/public/extensionPoints.ts";
+import {
+	MESSAGE_CLEANUP_INTERVAL,
+	MESSAGE_CLEANUP_THRESHOLD,
+} from "#plugin/logging/constants.ts";
 import { logEvent } from "#plugin/logging/helper/logging.ts";
 import { loggingConfigStore } from "#plugin/logging/index.ts";
 import {
@@ -17,9 +20,6 @@ import { Message, Routes, type PossiblyUncachedMessage } from "oceanic.js";
 
 const logger = moduleLogger();
 
-const MESSAGE_CLEANUP_INTERVAL = 30 * MINUTE;
-const MESSAGE_CLEANUP_THRESHOLD = 6 * HOUR;
-
 export default [
 	onBotInit(beginMessageCleanupLoop),
 	onBotEvent({ type: "messageCreate", listener: handleCreate }),

backend/src/plugin/tags/command/tag.ts

@@ -3,7 +3,8 @@ import { OptionType } from "#plugin/core/public/command.ts";
 import { defineCommand } from "#plugin/core/public/extensionPoints.ts";
 import { permissionsGuard } from "#plugin/core/public/helper/commandGuards.ts";
 import { icons } from "#plugin/core/public/icons.ts";
-import { MAX_TAG_NAME_LENGTH, tagsConfigStore } from "#plugin/tags/index.ts";
+import { MAX_TAG_NAME_LENGTH } from "#plugin/tags/constants.ts";
+import { tagsConfigStore } from "#plugin/tags/index.ts";
 import { getTag, searchTags } from "#plugin/tags/storage/tags.ts";
 
 export default defineCommand({

backend/src/plugin/tags/command/tagDelete.ts

@@ -3,7 +3,8 @@ import { OptionType } from "#plugin/core/public/command.ts";
 import { defineCommand } from "#plugin/core/public/extensionPoints.ts";
 import { permissionsGuard } from "#plugin/core/public/helper/commandGuards.ts";
 import { icons } from "#plugin/core/public/icons.ts";
-import { MAX_TAG_NAME_LENGTH, tagsConfigStore } from "#plugin/tags/index.ts";
+import { MAX_TAG_NAME_LENGTH } from "#plugin/tags/constants.ts";
+import { tagsConfigStore } from "#plugin/tags/index.ts";
 import { deleteTag, searchTags } from "#plugin/tags/storage/tags.ts";
 
 export default defineCommand({

backend/src/plugin/tags/command/tagSet.ts

@@ -6,8 +6,8 @@ import { icons } from "#plugin/core/public/icons.ts";
 import {
 	MAX_TAG_CONTENT_LENGTH,
 	MAX_TAG_NAME_LENGTH,
-	tagsConfigStore,
-} from "#plugin/tags/index.ts";
+} from "#plugin/tags/constants.ts";
+import { tagsConfigStore } from "#plugin/tags/index.ts";
 import {
 	createTag,
 	searchTags,

backend/src/plugin/tags/constants.ts

@@ -0,0 +1,2 @@
+export const MAX_TAG_NAME_LENGTH = 30;
+export const MAX_TAG_CONTENT_LENGTH = 4000;