Skip to content

Commit e490a59

Browse files
committed
Use less method property declarations
1 parent dae418c commit e490a59

5 files changed

Lines changed: 16 additions & 13 deletions

File tree

backend/src/plugin/core/public/command.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export interface BaseContext {
3333
user: User;
3434
member: Member;
3535
channel: AnyTextableGuildChannel;
36-
respond(reply: Reply): Promise<void>;
36+
respond: (reply: Reply) => Promise<void>;
3737
}
3838

3939
export interface CommandContext extends BaseContext {
@@ -45,7 +45,7 @@ export interface CommandContext extends BaseContext {
4545
export interface ComponentContext extends BaseContext {
4646
/** The ID of the user who initially ran the command */
4747
originalUserID: string;
48-
edit(reply: Reply): Promise<void>;
48+
edit: (reply: Reply) => Promise<void>;
4949
}
5050

5151
export interface ReplyObject extends Omit<CreateMessageOptions, "messageReference" | "tts" | "content"> {

backend/src/plugin/core/public/extensionPoints.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@ import type { ClientEvents } from "oceanic.js";
66

77
// custom implementations as fancy stuff with generics is required
88

9-
export interface BotEventListener<T extends keyof ClientEvents = keyof ClientEvents> {
9+
export interface BotEventListener<T extends keyof ClientEvents = any> {
1010
type: T;
11-
listener(...args: ClientEvents[T]): Promise<void> | void;
11+
listener: (...args: ClientEvents[T]) => Promise<void> | void;
1212
}
1313

1414
export function onBotEvent<T extends keyof ClientEvents>(listener: BotEventListener<T>): Contribution {

backend/src/plugin/core/public/helper/paginator.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ import { ComponentTypes } from "oceanic.js";
44

55
export interface Paginator<E, K> {
66
pageSize: number;
7-
getKey(entry: E): K;
8-
lookUp(context: BaseContext, query: PaginatorQuery<K>): Promise<E[]>;
9-
render(entries: E[]): Promise<ReplyObject> | ReplyObject;
7+
getKey: (entry: E) => K;
8+
lookUp: (context: BaseContext, query: PaginatorQuery<K>) => Promise<E[]>;
9+
render: (entries: E[]) => Promise<ReplyObject> | ReplyObject;
1010
}
1111

1212
export interface PaginatorQuery<K> {

backend/src/plugin/logging/logger/messages.ts

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { onBotEvent } from "#plugin/core/public/extensionPoints.ts";
66
import { logWithLogger } from "#plugin/logging/helper/webhooks.ts";
77
import { loggingConfigStore } from "#plugin/logging/index.ts";
88
import { cleanUpMessageCacheEntries, getMessageCacheEntry, takeMessageCacheEntry, upsertMessageCacheEntry, type MessageCacheEntry } from "#plugin/logging/storage/messageCache.ts";
9-
import { Message, Routes } from "oceanic.js";
9+
import { Message, Routes, type PossiblyUncachedMessage } from "oceanic.js";
1010

1111
const logger = moduleLogger();
1212

@@ -15,7 +15,11 @@ const MESSAGE_CLEANUP_THRESHOLD = 6 * HOUR;
1515

1616
export default [
1717
onBotInit(beginMessageCleanupLoop),
18-
onBotEvent({ type: "messageCreate", listener: handleCreate }),
18+
onBotEvent({
19+
type: "messageCreate", listener(e: Message) {
20+
21+
}
22+
}),
1923
onBotEvent({ type: "messageUpdate", listener: handleUpdate }),
2024
onBotEvent({ type: "messageDelete", listener: handleDelete }),
2125
];
@@ -89,7 +93,7 @@ async function handleUpdate(message: Message): Promise<void> {
8993
}
9094
}
9195

92-
async function handleDelete(message: Message): Promise<void> {
96+
async function handleDelete(message: PossiblyUncachedMessage): Promise<void> {
9397
if (message.guild == null)
9498
return;
9599

backend/src/plugin/moderation/helper/bulkAction.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ type BulkAction =
2626
duration?: number;
2727
memberRanking: MemberRanking;
2828

29-
check?(member: Member): Promise<string | true> | string | true;
30-
makeCase(options: Pick<CreateCaseOptions, "createdAt" | "expiresAt" | "actorID" | "targetID" | "dmDelivered">): CreateCaseOptions;
29+
check?: (member: Member) => Promise<string | true> | string | true;
30+
makeCase: (options: Pick<CreateCaseOptions, "createdAt" | "expiresAt" | "actorID" | "targetID" | "dmDelivered">) => CreateCaseOptions;
3131
};
3232

3333
export interface BulkSuccessEntry {
@@ -51,7 +51,6 @@ export async function doBulkAction(action: BulkAction): Promise<BulkResult> {
5151

5252
const members = await fetchMembersCached(action.guild, action.ids);
5353

54-
// eslint-disable-next-line @typescript-eslint/unbound-method
5554
action.check ??= () => true;
5655

5756
for (const targetID of action.ids) {

0 commit comments

Comments
 (0)