discordwebhook: log delivery events to module_events, not a missing table

logEvent inserted into a discord_events table that no migration ever
created, so every WebhookSent/WebhookError audit write failed with
"no such table: discord_events". Use the shared engine.EventLogger
(module_events) like the other modules instead.

Author: jveski

modules/discordwebhook/README.md

@@ -16,7 +16,7 @@ Any module (or SQL trigger) can deliver a message simply by inserting a row into
 
 ## Behavioral details
 
-- Backed by a SQLite table `discord_webhook_queue` created via migration on `New`; the `channel_id` column is added best-effort via `ALTER TABLE` on `New`. Also writes audit rows to a shared `discord_events` table (must exist; not created here).
+- Backed by a SQLite table `discord_webhook_queue` created via migration on `New`; the `channel_id` column is added best-effort via `ALTER TABLE` on `New`. Audit rows (`WebhookSent`/`WebhookError`) are written via the shared `engine.EventLogger` to the `module_events` table under module `discordwebhook`.
 - `AttachWorkers` registers two background workers:
   - Hourly cleanup deleting any queue rows older than 1 hour (`created` age > 3600s), regardless of delivery status.
   - 1Hz workqueue poller, rate-limited to 5 sends/sec globally (`maxRPS = 5`).

modules/discordwebhook/module.go

@@ -51,34 +51,28 @@ type MessageQueuer interface {
 type Module struct {
 	db     *sql.DB
 	sender Sender
+	events *engine.EventLogger
 }
 
-func New(d *sql.DB, sender Sender) *Module {
+func New(d *sql.DB, events *engine.EventLogger, sender Sender) *Module {
 	engine.MustMigrate(d, migration)
 	// channel_id generalizes the queue to bot-API channel delivery. ALTER
 	// TABLE ADD COLUMN can't use IF NOT EXISTS, so run it best-effort and
 	// ignore the "duplicate column" error on subsequent boots.
 	d.Exec("ALTER TABLE discord_webhook_queue ADD COLUMN channel_id TEXT NOT NULL DEFAULT ''")
-	m := &Module{db: d, sender: sender}
+	m := &Module{db: d, sender: sender, events: events}
 	if m.sender == nil {
 		m.sender = newNoopSender()
 	}
 	return m
 }
 
-// logEvent logs a Discord webhook event to the shared discord_events table.
+// logEvent records a Discord delivery event to the shared module_events table.
 func (m *Module) logEvent(ctx context.Context, eventType string, success bool, details string) {
-	successInt := 0
-	if success {
-		successInt = 1
-	}
-	_, err := m.db.ExecContext(ctx,
-		`INSERT INTO discord_events (event_type, success, details)
-		 VALUES (?, ?, ?)`,
-		eventType, successInt, details)
-	if err != nil {
-		slog.Error("failed to log discord webhook event", "error", err, "eventType", eventType)
+	if m.events == nil {
+		return
 	}
+	m.events.LogEvent(ctx, 0, eventType, "", "", success, details)
 }
 
 func (m *Module) AttachWorkers(mgr *engine.ProcMgr) {

modules/discordwebhook/module_test.go

@@ -11,7 +11,7 @@ import (
 func TestQueueMessage(t *testing.T) {
 	testDB := engine.OpenTestDB(t)
 
-	m := New(testDB, nil)
+	m := New(testDB, nil, nil)
 	ctx := t.Context()
 
 	err := m.QueueMessage(ctx, "https://discord.com/api/webhooks/test", `{"content":"test message"}`)
@@ -32,7 +32,7 @@ func TestQueueMessage(t *testing.T) {
 func TestGetItem(t *testing.T) {
 	testDB := engine.OpenTestDB(t)
 
-	m := New(testDB, nil)
+	m := New(testDB, nil, nil)
 	ctx := t.Context()
 
 	err := m.QueueMessage(ctx, "https://discord.com/api/webhooks/test", `{"content":"hello"}`)
@@ -48,7 +48,7 @@ func TestGetItem(t *testing.T) {
 func TestUpdateItemSuccess(t *testing.T) {
 	testDB := engine.OpenTestDB(t)
 
-	m := New(testDB, nil)
+	m := New(testDB, nil, nil)
 	ctx := t.Context()
 
 	err := m.QueueMessage(ctx, "https://discord.com/api/webhooks/test", `{"content":"test"}`)
@@ -71,7 +71,7 @@ func TestUpdateItemSuccess(t *testing.T) {
 func TestUpdateItemFailure(t *testing.T) {
 	testDB := engine.OpenTestDB(t)
 
-	m := New(testDB, nil)
+	m := New(testDB, nil, nil)
 	ctx := t.Context()
 
 	err := m.QueueMessage(ctx, "https://discord.com/api/webhooks/test", `{"content":"test"}`)

modules/register.go

@@ -112,7 +112,7 @@ func Register(a *engine.App, opts Options) *auth.Module {
 		}
 		return cfg.BotToken, nil
 	})
-	discordWebhookMod := discordwebhook.New(opts.Database, webhookSender)
+	discordWebhookMod := discordwebhook.New(opts.Database, engine.NewEventLogger(opts.Database, "discordwebhook"), webhookSender)
 	a.Add(discordWebhookMod)
 
 	discordMod := discord.New(opts.Database, opts.Self, opts.DiscordIssuer, engine.NewEventLogger(opts.Database, "discord"))