Skip to content

perf: skip GameDataParser if there are no subscribers #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alrun3 wants to merge 1 commit into from
Closed

perf: skip GameDataParser if there are no subscribers #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion W3GNET/Parsers/ReplayParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
private MetadataParser metadataParser;
private GameDataParser gameDataParser;

public ReplayParser()

Check warning on line 24 in W3GNET/Parsers/ReplayParser.cs

View workflow job for this annotation

GitHub Actions / build 

Non-nullable event 'OnBasicReplayInformation' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the event as nullable.

Check warning on line 24 in W3GNET/Parsers/ReplayParser.cs

View workflow job for this annotation

GitHub Actions / build 

Non-nullable event 'OnGameDataBlock' must contain a non-null value when exiting constructor. Consider adding the 'required' modifier or declaring the event as nullable.
{
rawParser = new CustomReplayParser();
metadataParser = new MetadataParser();
Expand All @@ -46,7 +46,11 @@
};

OnBasicReplayInformation?.Invoke(result);
await gameDataParser.Parse(metadataParserResult.gameData);

if (OnGameDataBlock != null)
{
await gameDataParser.Parse(metadataParserResult.gameData);
}

return result;
}
Expand Down
Loading