Skip to content

feat: Add "Use Polling" flag for watchers#592

Open
scme0 wants to merge 4 commits into
TheNickOfTime:mainfrom
scme0:add-watch-polling-option
Open

feat: Add "Use Polling" flag for watchers#592
scme0 wants to merge 4 commits into
TheNickOfTime:mainfrom
scme0:add-watch-polling-option

Conversation

@scme0
Copy link
Copy Markdown

@scme0 scme0 commented Dec 13, 2025

Feature Request: #591

I noticed that watchers setup on directories that are from a network mount (in my case NFS), they weren't picking up any file changes.

I had a quick look at the watching library and saw that there was a usePolling option for this specific case which is not currently being used in your app.

Screenshot 2025-12-13 at 23 44 44 Screenshot 2025-12-13 at 23 44 35

I've added it in as an option when creating the watcher. I've built the server image and tested it in my Kubernetes cluster and it seems to work now, I'm now getting file change events in the server log.

Screenshot 2025-12-13 at 23 45 42

@TheNickOfTime
Copy link
Copy Markdown
Owner

Hey thanks for your PR, I'll take a look!

Copy link
Copy Markdown
Owner

@TheNickOfTime TheNickOfTime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Currently your migration will not run because the file hasn't been manually added to the custom migration provider at server/src/scripts/database/plugins/provider.ts (this is necessary for migrations to still run after the program is bundled with esbuild). I've put some additional notes for small tweaks as well.

Comment thread server/src/scripts/database/migrations/migration-3.ts Outdated
Comment thread server/src/scripts/database/migrations/migration-3.ts Outdated
Comment thread client/src/components/cards/watcher-card/index.tsx Outdated
Comment thread client/src/components/overlays/register-watcher/index.tsx Outdated
@scme0
Copy link
Copy Markdown
Author

scme0 commented Jan 12, 2026

@TheNickOfTime Sorry for the delay, I've been away over the Christmas break. Thanks for the review and comments! I'll address your comments sometime this week 👍

@scme0
Copy link
Copy Markdown
Author

scme0 commented Jan 23, 2026

@TheNickOfTime Apologies again for the delay, I've applied your suggestions and add migration-3 to the CustomMigrationProvider. Let me know if there is anything else. Thank you 🙏

@scme0 scme0 requested a review from TheNickOfTime January 29, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow watchers to use the "Use Polling" flag for network mounted directories

2 participants