feat: Add "Use Polling" flag for watchers#592
Conversation
|
Hey thanks for your PR, I'll take a look! |
TheNickOfTime
left a comment
There was a problem hiding this comment.
Looks good overall! Currently your migration will not run because the file hasn't been manually added to the custom migration provider at server/src/scripts/database/plugins/provider.ts (this is necessary for migrations to still run after the program is bundled with esbuild). I've put some additional notes for small tweaks as well.
|
@TheNickOfTime Sorry for the delay, I've been away over the Christmas break. Thanks for the review and comments! I'll address your comments sometime this week 👍 |
Co-authored-by: Nick Cunningham <10342737+TheNickOfTime@users.noreply.github.com>
|
@TheNickOfTime Apologies again for the delay, I've applied your suggestions and add migration-3 to the CustomMigrationProvider. Let me know if there is anything else. Thank you 🙏 |
Feature Request: #591
I noticed that watchers setup on directories that are from a network mount (in my case NFS), they weren't picking up any file changes.
I had a quick look at the watching library and saw that there was a
usePollingoption for this specific case which is not currently being used in your app.I've added it in as an option when creating the watcher. I've built the server image and tested it in my Kubernetes cluster and it seems to work now, I'm now getting file change events in the server log.