Skip to content

Pin Node version to major#873

Open
mao-sz wants to merge 2 commits into
TheOdinProject:mainfrom
mao-sz:pin-node-version
Open

Pin Node version to major#873
mao-sz wants to merge 2 commits into
TheOdinProject:mainfrom
mao-sz:pin-node-version

Conversation

@mao-sz

@mao-sz mao-sz commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Because

It'd be better to have more control over what version of Node.js the bot uses, and manually update to a newer LTS only after testing.

This PR

  • Pins required Node version to ^24.10 (we use features made stable or introduced from 24.10
  • Prevents npm from installing package versions if they're not compatible with the pinned major version
  • Adds script for updating the version pin

Issue

Closes #680

Additional Information

Depending on what gets merged first between this and #869, I'll update the contributing guide/repo wiki accordingly for version update instructions.

Update script can be run like

NEW_NODE_VERSION=^26 npm run pin-node

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR adds new features or functionality, I have added new tests
  • If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

mao-sz added 2 commits June 30, 2026 09:55
"engines" required for Heroku but won't affect local dev
"devEngines" covers that

24.10 minimum because we use some features made stable or introduced in
24.10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include engines and devEngines fields in package.json?

1 participant