Pin Node version to major#873
Open
mao-sz wants to merge 2 commits into
Open
Conversation
"engines" required for Heroku but won't affect local dev "devEngines" covers that 24.10 minimum because we use some features made stable or introduced in 24.10
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
It'd be better to have more control over what version of Node.js the bot uses, and manually update to a newer LTS only after testing.
This PR
Issue
Closes #680
Additional Information
Depending on what gets merged first between this and #869, I'll update the contributing guide/repo wiki accordingly for version update instructions.
Update script can be run like
Pull Request Requirements
location of change: brief description of changeformat, e.g.Callbacks command: Update verbiageBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection