feat: adjustments endpoints

Author: TheOutdoorProgrammer

src/controllers/adjustEndpoints.js

@@ -1,6 +1,7 @@
 /**
  * Adjust endpoints endpoint (POST /adjustendpoints)
  * Filters and adjusts endpoints based on provider capabilities
+ * Supports A, TXT, and CNAME record types
  */
 
 const config = require('../config');
@@ -41,25 +42,25 @@ function adjustEndpoints(req, res) {
     return res.status(400).json({ error: 'Request body must be an array of endpoints' });
   }
 
-  // Filter endpoints:
-  // 1. Keep only A and TXT record types
-  // 2. Remove invalid endpoints
-  const adjustedEndpoints = endpoints.filter(endpoint => {
-    // Check if valid endpoint structure
-    if (!endpoint || typeof endpoint !== 'object') {
-      logger.warn('Skipping invalid endpoint (not an object)');
-      return false;
-    }
-    
-    // Only support A and TXT records
-    const recordType = endpoint.recordType;
-    if (recordType !== 'A' && recordType !== 'TXT') {
-      logger.debug('Filtering out unsupported record type', { 
-        dnsName: endpoint.dnsName, 
-        recordType 
-      });
-      return false;
-    }
+   // Filter endpoints:
+   // 1. Keep only A, TXT, and CNAME record types
+   // 2. Remove invalid endpoints
+   const adjustedEndpoints = endpoints.filter(endpoint => {
+     // Check if valid endpoint structure
+     if (!endpoint || typeof endpoint !== 'object') {
+       logger.warn('Skipping invalid endpoint (not an object)');
+       return false;
+     }
+
+     // Support A, TXT, and CNAME records (as advertised in README)
+     const recordType = endpoint.recordType;
+     if (recordType !== 'A' && recordType !== 'TXT' && recordType !== 'CNAME') {
+       logger.debug('Filtering out unsupported record type', {
+         dnsName: endpoint.dnsName,
+         recordType
+       });
+       return false;
+     }
 
     // Validate endpoint structure
     if (!validator.isValidEndpoint(endpoint)) {

test-adjust-endpoints.js

@@ -0,0 +1,83 @@
+#!/usr/bin/env node
+/**
+ * Test script for adjustEndpoints CNAME support
+ */
+
+// Mock logger
+const logger = {
+  info: () => {},
+  warn: () => {},
+  debug: () => {}
+};
+
+// Mock validator
+const validator = {
+  isValidEndpoint: (endpoint) => {
+    // Simple validation - just check required fields exist
+    return endpoint && endpoint.dnsName && endpoint.targets && endpoint.recordType;
+  }
+};
+
+// Mock config
+const config = {
+  contentType: 'application/external.dns.webhook+json;version=1'
+};
+
+// Mock express objects
+const mockReq = {
+  body: [],
+  get: () => null
+};
+
+const mockRes = {
+  status: function(code) { this.statusCode = code; return this; },
+  json: function(data) { this.data = data; return this; },
+  setHeader: function() {},
+  send: function(data) { this.sentData = data; }
+};
+
+// Import and test adjustEndpoints
+const adjustEndpoints = require('./src/controllers/adjustEndpoints');
+
+// Test data
+const testEndpoints = [
+  { dnsName: 'a.example.com', targets: ['1.2.3.4'], recordType: 'A' },
+  { dnsName: 'txt.example.com', targets: ['test=value'], recordType: 'TXT' },
+  { dnsName: 'cname.example.com', targets: ['target.example.com'], recordType: 'CNAME' },
+  { dnsName: 'invalid.example.com', targets: ['1.2.3.4'], recordType: 'AAAA' } // Should be filtered out
+];
+
+console.log('Testing adjustEndpoints CNAME support...');
+
+// Mock the request
+mockReq.body = testEndpoints;
+
+// Call adjustEndpoints
+adjustEndpoints(mockReq, mockRes);
+
+// Parse the response
+const response = JSON.parse(mockRes.sentData);
+console.log('Original endpoints:', testEndpoints.length);
+console.log('Filtered endpoints:', response.length);
+
+console.log('Results:');
+response.forEach(endpoint => {
+  console.log(`  ${endpoint.recordType}: ${endpoint.dnsName}`);
+});
+
+const cnameCount = response.filter(e => e.recordType === 'CNAME').length;
+const aCount = response.filter(e => e.recordType === 'A').length;
+const txtCount = response.filter(e => e.recordType === 'TXT').length;
+const invalidCount = response.filter(e => e.recordType === 'AAAA').length;
+
+console.log(`\nSummary:`);
+console.log(`  A records: ${aCount}`);
+console.log(`  TXT records: ${txtCount}`);
+console.log(`  CNAME records: ${cnameCount}`);
+console.log(`  Invalid records: ${invalidCount}`);
+
+if (cnameCount > 0 && invalidCount === 0) {
+  console.log('\n✅ SUCCESS: CNAME records are now supported and invalid records are filtered!');
+} else {
+  console.log('\n❌ FAILURE: CNAME support test failed');
+}