feat: better domain filtering

Author: TheOutdoorProgrammer

README.md

@@ -41,23 +41,25 @@ This webhook provider allows Kubernetes external-dns to automatically create, up
 SSH into your Firewalla as the `pi` user and run:
 
 ```bash
-curl -fsSL https://raw.githubusercontent.com/TheOutdoorProgrammer/external-dns-firewalla-webhook/main/scripts/install.sh | bash
+curl -fsSL https://raw.githubusercontent.com/TheOutdoorProgrammer/external-dns-firewalla-webhook/main/scripts/install.sh | bash -s -- "home.local,*.home.local"
 ```
 
+**Important**: Replace `home.local,*.home.local` with your actual domain filter.
+
 **Note**: The script will prompt for your sudo password when needed for system configuration.
 
 This will:
 - Clone the repository (with bundled dependencies)
 - Verify dependencies
 - Configure the service (with sudo)
-- Prompt for your domain filter
+- Set up your domain filter
 - Start the webhook provider
 
 **Note**: Dependencies (Express.js) are bundled in the repository since npm is not available on Firewalla.
 
-### Manual Installation
+### Interactive Installation
 
-If you prefer to review the installation script first:
+If you prefer an interactive installation that prompts for configuration:
 
 1. SSH into your Firewalla device as the `pi` user:
    ```bash
@@ -70,7 +72,7 @@ If you prefer to review the installation script first:
    cd external-dns-firewalla-webhook
    ```
 
-3. Review the installation script:
+3. Review the installation script (optional):
    ```bash
    cat scripts/install.sh
    ```
@@ -80,15 +82,23 @@ If you prefer to review the installation script first:
    ./scripts/install.sh
    ```
 
-   The script will ask for your sudo password when needed.
+   The script will ask for your sudo password and domain filter when needed.
 
-5. Follow the prompts to configure your domain filter (e.g., `home.local,*.home.local`)
+5. Enter your domain filter when prompted (e.g., `home.local,*.home.local`)
 
 6. Verify the service is running:
    ```bash
    sudo systemctl status external-dns-firewalla-webhook
    ```
 
+### Alternative: Pass Domain Filter as Argument
+
+You can also provide the domain filter directly:
+
+```bash
+./scripts/install.sh "home.local,*.home.local"
+```
+
 ### Configuration in Kubernetes
 
 #### Using Helm Chart (Recommended)

scripts/install.sh

@@ -3,6 +3,10 @@
 # Installation script for External-DNS Firewalla Webhook Provider
 # This script installs and configures the webhook provider on Firewalla
 #
+# Usage:
+#   ./scripts/install.sh [domain-filter]
+#   curl -fsSL https://raw.githubusercontent.com/.../install.sh | bash -s -- "example.com,*.example.com"
+#
 set -e
 
 # Colors for output
@@ -11,6 +15,9 @@ GREEN='\033[0;32m'
 YELLOW='\033[1;33m'
 NC='\033[0m' # No Color
 
+# Get domain filter from first argument if provided
+DOMAIN_FILTER="${1:-}"
+
 # Configuration
 INSTALL_DIR="/opt/external-dns-firewalla-webhook"
 SERVICE_NAME="external-dns-firewalla-webhook"
@@ -117,9 +124,31 @@ echo "Dependencies verified (bundled in repository)"
 # Configure environment
 echo -e "${GREEN}[6/9]${NC} Configuring environment..."
 if [ ! -s "$INSTALL_DIR/.env" ] || ! grep -q "DOMAIN_FILTER=" "$INSTALL_DIR/.env" || grep -q "DOMAIN_FILTER=example.com" "$INSTALL_DIR/.env"; then
-    echo ""
-    echo -e "${YELLOW}Please enter your domain filter (comma-separated, e.g., example.com,*.example.com):${NC}"
-    read -p "Domain filter: " DOMAIN_FILTER
+    # If domain filter not provided as argument, try to read from stdin
+    if [ -z "$DOMAIN_FILTER" ]; then
+        # Check if stdin is a terminal (interactive)
+        if [ -t 0 ]; then
+            echo ""
+            echo -e "${YELLOW}Please enter your domain filter (comma-separated, e.g., example.com,*.example.com):${NC}"
+            read -p "Domain filter: " DOMAIN_FILTER
+        else
+            # Not interactive (piped from curl)
+            echo ""
+            echo -e "${RED}ERROR: Domain filter is required but not provided${NC}"
+            echo ""
+            echo "When using the one-line install, provide your domain filter as an argument:"
+            echo ""
+            echo "  curl -fsSL https://raw.githubusercontent.com/.../install.sh | bash -s -- \"example.com,*.example.com\""
+            echo ""
+            echo "Alternatively, run the installation interactively:"
+            echo ""
+            echo "  git clone $GITHUB_REPO"
+            echo "  cd external-dns-firewalla-webhook"
+            echo "  ./scripts/install.sh"
+            echo ""
+            exit 1
+        fi
+    fi
 
     if [ -z "$DOMAIN_FILTER" ]; then
         echo -e "${RED}ERROR: Domain filter cannot be empty${NC}"