Skip to content

Commit d2f2909

Browse files
feat: bundle express
1 parent d83565f commit d2f2909

623 files changed

Lines changed: 67247 additions & 50 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Node.js
2-
node_modules/
2+
# Note: node_modules is NOT ignored - we bundle express for Firewalla
33
npm-debug.log*
44
yarn-debug.log*
55
yarn-error.log*

README.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@ This webhook provider allows Kubernetes external-dns to automatically create, up
2929
## Prerequisites
3030

3131
- **Firewalla device** (Gold, Purple, Red, or any model with SSH access)
32-
- **Firewalla firmware** with systemd and Node.js 12.14.0+ (pre-installed on most models)
32+
- **Firewalla firmware** with Node.js at `/home/pi/firewalla/bin/node` (pre-installed on most models)
3333
- **Kubernetes cluster** with external-dns installed
34-
- **SSH access** to your Firewalla device
34+
- **SSH access** to your Firewalla device as the `pi` user
3535
- **Sudo privileges** on Firewalla
3636

3737
## Quick Start
@@ -47,12 +47,14 @@ curl -fsSL https://raw.githubusercontent.com/TheOutdoorProgrammer/external-dns-f
4747
**Note**: The script will prompt for your sudo password when needed for system configuration.
4848

4949
This will:
50-
- Clone the repository
51-
- Install all dependencies
50+
- Clone the repository (with bundled dependencies)
51+
- Verify dependencies
5252
- Configure the service (with sudo)
5353
- Prompt for your domain filter
5454
- Start the webhook provider
5555

56+
**Note**: Dependencies (Express.js) are bundled in the repository since npm is not available on Firewalla.
57+
5658
### Manual Installation
5759

5860
If you prefer to review the installation script first:
@@ -404,9 +406,9 @@ txt-record=external-dns-a-example.home.local,"heritage=external-dns,external-dns
404406
sudo journalctl -u external-dns-firewalla-webhook -n 50
405407
```
406408

407-
2. Verify Node.js is installed:
409+
2. Verify Node.js is installed at the Firewalla path:
408410
```bash
409-
node -v # Should be 12.14.0 or higher
411+
/home/pi/firewalla/bin/node -v # Should be 12.14.0 or higher
410412
```
411413

412414
3. Check the .env file:

node_modules/.bin/mime

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)