CI (Claude) code review feedback

Author: tdilauro

src/palace/manager/celery/tasks/marc.py

@@ -37,10 +37,12 @@
 # LibraryInfo fields that change between runs without a configuration change.
 _VOLATILE_LIBRARY_INFO_FIELDS = frozenset({"last_updated", "needs_update"})
 
-# LibraryInfo tuple fields whose values are compared as unordered sets.
+# LibraryInfo tuple fields compared order-independently. Duplicate values are
+# significant: each web client URL produces its own 856 field, so a duplicate
+# URL changes the export and must register as a difference.
 # TODO: The `filtered_audiences` and `filtered_genres` library settings are
 #  compared below, but changing them does not yet queue a MARC export reset.
-_UNORDERED_LIBRARY_INFO_FIELDS = frozenset(
+_ORDER_INSENSITIVE_LIBRARY_INFO_FIELDS = frozenset(
     {"web_client_urls", "filtered_audiences", "filtered_genres"}
 )
 
@@ -128,12 +130,13 @@ def _export_settings_changed(snapshot: LibraryInfo, current: LibraryInfo) -> boo
     """Whether a library's export-affecting settings differ between two LibraryInfo.
 
     Ignores the fields that may change between runs without affecting the export
-    and compares the tuple fields as unordered sets of values.
+    and compares the tuple fields order-independently, with duplicate values
+    significant.
     """
 
     def comparable(info: LibraryInfo) -> dict[str, Any]:
         dumped = info.model_dump(exclude=set(_VOLATILE_LIBRARY_INFO_FIELDS))
-        for field in _UNORDERED_LIBRARY_INFO_FIELDS:
+        for field in _ORDER_INSENSITIVE_LIBRARY_INFO_FIELDS:
             dumped[field] = sorted(dumped[field])
         return dumped