CI (Claude) code review feedback

Author: tdilauro

src/palace/manager/celery/tasks/marc.py

@@ -491,7 +491,7 @@ def marc_export_reset(task: Task, library_id: int) -> None:
     Reset MARC export for a library so that the next export run behaves like a
     first run, producing both a new full export and a full-content delta.
     Deletes the MarcFile records and associated S3 objects for the library's
-    MARC-enabled collections, along with the corresponding S3 objects.
+    MARC-enabled collections.
 
     The records are deleted in a single transaction, so a failure cannot leave the
     reset half-applied. The S3 objects are then deleted best-effort: a failed

src/palace/manager/integration/catalog/marc/exporter.py

@@ -184,17 +184,6 @@ def _marc_enabled_collections_query(library: Library) -> Select:
             )
         )
 
-    @staticmethod
-    def marc_enabled_collections(
-        session: Session, library: Library
-    ) -> list[Collection]:
-        """Return all MARC-export-enabled collections associated with this library."""
-        return (
-            session.execute(MarcExporter._marc_enabled_collections_query(library))
-            .scalars()
-            .all()
-        )
-
     @staticmethod
     def files_for_reset(session: Session, library: Library) -> Generator[MarcFile]:
         """MarcFile records for a library's MARC-enabled collections.

tests/manager/integration/catalog/marc/test_exporter.py

@@ -635,31 +635,6 @@ def test_enabled_libraries_includes_filtering_settings(
         assert library2_info.filtered_audiences == ()
         assert library2_info.filtered_genres == ()
 
-    def test_marc_enabled_collections(
-        self,
-        db: DatabaseTransactionFixture,
-        marc_exporter_fixture: MarcExporterFixture,
-    ) -> None:
-        library1 = marc_exporter_fixture.library1
-
-        # No collections have export_marc_records enabled.
-        assert MarcExporter.marc_enabled_collections(db.session, library1) == []
-
-        # Enable collection1 (associated with library1) and collection3 (associated with library2 only).
-        marc_exporter_fixture.collection1.export_marc_records = True
-        marc_exporter_fixture.collection3.export_marc_records = True
-
-        result = MarcExporter.marc_enabled_collections(db.session, library1)
-        assert result == [marc_exporter_fixture.collection1]
-
-        # Enable collection2, which is also associated with library1.
-        marc_exporter_fixture.collection2.export_marc_records = True
-        result = MarcExporter.marc_enabled_collections(db.session, library1)
-        assert set(result) == {
-            marc_exporter_fixture.collection1,
-            marc_exporter_fixture.collection2,
-        }
-
     def test_files_for_reset(
         self,
         db: DatabaseTransactionFixture,