Bump pymarc from 5.3.1 to 5.4.0#3534
Merged
Merged
Conversation
Bumps [pymarc](https://gitlab.com/pymarc/pymarc) from 5.3.1 to 5.4.0. - [Release notes](https://gitlab.com/pymarc/pymarc/tags) - [Commits](https://gitlab.com/pymarc/pymarc/compare/v5.3.1...v5.4.0) --- updated-dependencies: - dependency-name: pymarc dependency-version: 5.4.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
pymarc 5.4.0 added type annotations, typing Record.leader as a Leader. _copy_record passes record.leader into _record, which previously only accepted str | None, so mypy flagged the mismatch. Widen _record to accept a Leader, and cast at the Record(leader=...) constructor to work around pymarc typing that parameter as str even though it accepts a Leader at runtime (upstream fix: pymarc!229).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3534 +/- ##
==========================================
+ Coverage 93.45% 93.46% +0.01%
==========================================
Files 511 512 +1
Lines 46494 46615 +121
Branches 6346 6352 +6
==========================================
+ Hits 43450 43570 +120
- Misses 1968 1969 +1
Partials 1076 1076 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps pymarc from 5.3.1 to 5.4.0.
Release notes
Sourced from pymarc's releases.
Commits
b1a69aeMerge branch 't215-deps' into 'main'007d3b7Update the version!166ae8cMerge branch 'constructor-searching-optimizations' into 'main'c1b9ea5Optimize hot path methods881f94bMerge branch 'fixed-212-bad-subfield' into 'main'255d3e4Fixed: emit more information on a bad subfield code warning4acb4bbMerge branch 'update-gitlab-pipeline-deps' into 'main'5bcabd3Fixed: node depends on libatomic1d208df4Merge branch 'pyright' into 'main'8c7d688Add pyrightDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)