You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enable monospace font rendering for form fields in the OIDC and SAML patron authentication configuration models that contain code-like content — regular expressions, filter expressions, JSON, and XML/PEM blobs.
Motivation and Context
Fields holding structured or code-like values (regex patterns, Python expressions, XML metadata, JSON objects, private keys) are easier to read and edit in a monospace font. This sets use_monospace_font=True on those fields in the admin UI so their content renders as expected.
How Has This Been Tested?
Manual testing in local dev environment to verify that fields display with correct font family.
No logic changes, so existing tests should continue to pass.
Checklist
N/A - I have updated the documentation accordingly.
Verify use_monospace_font is a valid, correctly-serialized flag
Check that flagged fields are all code-like
Check for missed / inconsistent fields
Summary
This is a clean, low-risk, purely additive change. Each of the 11 additions sets use_monospace_font=True on a form field whose value is genuinely code-like — regex patterns, Python filter expressions (TEXTAREA), JSON blobs (extra_data), and XML/PEM material (service_provider_xml_metadata, service_provider_private_key, non_federated_identity_provider_xml_metadata). The flag is a well-supported hint on FormMetadata (defaults to False, serialized in to_dict at src/palace/manager/integration/settings.py:187-188), and its behavior is already covered generically in tests/manager/integration/test_settings.py, so no new tests are warranted for what is effectively a per-field UI hint. I also checked for consistency: the only TEXTAREA field left without the flag is OIDC auth_link_description (model.py:411-423), which holds patron-facing prose ("Log in with your university credentials") rather than code — correctly excluded. All Pattern/JSON/code-bearing TEXTAREA fields in both models are covered. No issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable monospace font rendering for form fields in the OIDC and SAML patron authentication configuration models that contain code-like content — regular expressions, filter expressions, JSON, and XML/PEM blobs.
Motivation and Context
Fields holding structured or code-like values (regex patterns, Python expressions, XML metadata, JSON objects, private keys) are easier to read and edit in a monospace font. This sets
use_monospace_font=Trueon those fields in the admin UI so their content renders as expected.How Has This Been Tested?
Checklist