fix(jira): stop claiming phantom TestFlight builds; render real ADF; fix points field; drop noise-author lines

The merge/PR Jira automation made human-visible false or noisy claims:

1. "Ready for QA: TestFlight build N" was posted on EVERY merge, including
   develop merges that upload nothing. The number was whatever
   CURRENT_PROJECT_VERSION happened to grep first, so QA was pointed at a build
   that predated (and lacked) the fix. Now add_build_info takes a version +
   uploaded flag and only claims a TestFlight build when one was actually
   produced (main release, or a develop merge that bumped the build). Otherwise
   it says the change is merged and tells QA to hold for the next release build.
   jira-update-on-merge.yml computes `uploaded` (base==main, or build number
   changed vs first parent) and reads the Palace app's version robustly (max
   build / highest marketing version, not `grep -m1 | head -1`).

2. The build comment used Jira wiki markup pushed through a plain-text ADF node,
   so it rendered as literal asterisks and a dead link. It is now built as real
   ADF (strong marks + a link node).

3. Story points were written to the unused customfield_10016; the board reads
   customfield_10033. Fixed read + write everywhere.

4. Comments embedded the local git author ("t <t@t.io>") in add_fix_comment's
   traceability block and link_commit's output — meaningless to a QA/PM reader.
   Dropped the author line from both; the commit SHA is the traceability anchor.
   Goal: every automated comment reads clean to a human, no mystery authors.

Also: add_build_info updates an existing per-PR comment instead of duplicating,
and link_commit skips a SHA that's already linked.

**Scope:** dev tooling only — scripts/jira-integration.sh and the two Jira
GitHub Actions workflows. No app/production code, no test-affecting change.
**Not done:** did not scrub already-posted comments in this commit (done
separately on the board); did not add a bash test harness (none exists; verified
via bash -n + offline ADF/version dry-runs).
**Deferred:** generate-jira-tickets.py hardcodes LABEL="pp-4020" regardless of
--parent — a separate, unrelated cleanup.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: t

.github/workflows/jira-pr-opened.yml

@@ -62,7 +62,9 @@ jobs:
       - name: Get build number
         id: build
         run: |
-          BUILD_NUM=$(grep -m1 'CURRENT_PROJECT_VERSION' Palace.xcodeproj/project.pbxproj | grep -oE '[0-9]+' | head -1)
+          # Read the Palace app target's build number (max), not whichever
+          # CURRENT_PROJECT_VERSION sorts first (a placeholder target carries "=1").
+          BUILD_NUM=$(grep -oE 'CURRENT_PROJECT_VERSION = [0-9]+' Palace.xcodeproj/project.pbxproj | grep -oE '[0-9]+' | sort -n | tail -1)
           echo "number=$BUILD_NUM" >> $GITHUB_OUTPUT
           echo "📦 Build number: $BUILD_NUM"
 

.github/workflows/jira-update-on-merge.yml

@@ -16,13 +16,37 @@ jobs:
         with:
           fetch-depth: 0
 
-      - name: Get build number
+      - name: Resolve app version + upload status
         id: build
+        env:
+          BASE_REF: ${{ github.event.pull_request.base.ref }}
         run: |
-          # Extract build number from project.pbxproj
-          BUILD_NUM=$(grep -m1 'CURRENT_PROJECT_VERSION' Palace.xcodeproj/project.pbxproj | grep -oE '[0-9]+' | head -1)
+          PBX=Palace.xcodeproj/project.pbxproj
+          # The Palace app target carries the real values; a placeholder target in the
+          # same pbxproj carries CURRENT_PROJECT_VERSION=1 / MARKETING_VERSION=1.0. The
+          # old `grep -m1 ... | head -1` returned whichever sorted first in the file —
+          # a pbxproj regen floating the "=1" target up would have stamped "build 1" on
+          # every ticket. Take the app's values: max build, highest marketing version.
+          read_build() { grep -oE 'CURRENT_PROJECT_VERSION = [0-9]+' "$1" 2>/dev/null | grep -oE '[0-9]+' | sort -n | tail -1; }
+          BUILD_NUM=$(read_build "$PBX")
+          MKT=$(grep -oE 'MARKETING_VERSION = [0-9.]+' "$PBX" | sed -E 's/.*= //' | sort -V | tail -1)
           echo "number=$BUILD_NUM" >> $GITHUB_OUTPUT
-          echo "📦 Build number: $BUILD_NUM"
+          echo "version=$MKT" >> $GITHUB_OUTPUT
+
+          # Did this land actually produce a TestFlight build? A merge alone does NOT.
+          # main merges are releases (always uploaded). A develop merge only produces a
+          # build when it bumped CURRENT_PROJECT_VERSION (mirrors upload-on-merge.yml's
+          # version_changed gate). Compare this merge commit's build number to its first
+          # parent (the base-branch tip before the merge).
+          PREV_BUILD=$(git show 'HEAD^1:'"$PBX" 2>/dev/null | grep -oE 'CURRENT_PROJECT_VERSION = [0-9]+' | grep -oE '[0-9]+' | sort -n | tail -1 || echo "")
+          UPLOADED=false
+          if [ "$BASE_REF" = "main" ]; then
+            UPLOADED=true
+          elif [ -n "$PREV_BUILD" ] && [ "$PREV_BUILD" != "$BUILD_NUM" ]; then
+            UPLOADED=true
+          fi
+          echo "uploaded=$UPLOADED" >> $GITHUB_OUTPUT
+          echo "📦 $MKT ($BUILD_NUM) — base=$BASE_REF prev_build=${PREV_BUILD:-none} uploaded=$UPLOADED"
           
       - name: Extract Jira tickets
         id: tickets
@@ -65,6 +89,8 @@ jobs:
           JIRA_EMAIL: ${{ secrets.JIRA_PERSONAL_EMAIL }}
           JIRA_API_TOKEN: ${{ secrets.JIRA_PERSONAL_API_TOKEN }}
           BUILD_NUM: ${{ steps.build.outputs.number }}
+          APP_VERSION: ${{ steps.build.outputs.version }}
+          UPLOADED: ${{ steps.build.outputs.uploaded }}
           PR_NUM: ${{ github.event.pull_request.number }}
           PR_TITLE: ${{ github.event.pull_request.title }}
           BRANCH: ${{ github.event.pull_request.base.ref }}
@@ -82,8 +108,8 @@ jobs:
           for TICKET in $TICKETS; do
             echo "📝 Updating $TICKET..."
             
-            # Add build info comment
-            ./scripts/jira-integration.sh add-build-info "$TICKET" "$BUILD_NUM" "$PR_NUM" "$PR_TITLE" "$BRANCH" || {
+            # Add build info comment (honest: only claims a TestFlight build when UPLOADED=true)
+            ./scripts/jira-integration.sh add-build-info "$TICKET" "$BUILD_NUM" "$PR_NUM" "$PR_TITLE" "$BRANCH" "$APP_VERSION" "$UPLOADED" || {
               echo "⚠️ Failed to add comment to $TICKET"
             }
             
@@ -109,6 +135,11 @@ jobs:
           echo "" >> $GITHUB_STEP_SUMMARY
           echo "**Tickets Updated:** ${{ steps.tickets.outputs.list }}" >> $GITHUB_STEP_SUMMARY
           echo "" >> $GITHUB_STEP_SUMMARY
-          echo "**Build:** ${{ steps.build.outputs.number }}" >> $GITHUB_STEP_SUMMARY
+          echo "**Version:** ${{ steps.build.outputs.version }} (${{ steps.build.outputs.number }})" >> $GITHUB_STEP_SUMMARY
+          if [ "${{ steps.build.outputs.uploaded }}" = "true" ]; then
+            echo "**TestFlight:** uploaded — tickets told they are ready for QA" >> $GITHUB_STEP_SUMMARY
+          else
+            echo "**TestFlight:** not uploaded (no version bump) — tickets told to hold QA for the next release build" >> $GITHUB_STEP_SUMMARY
+          fi
           echo "**PR:** #${{ github.event.pull_request.number }}" >> $GITHUB_STEP_SUMMARY
           echo "**Branch:** ${{ github.event.pull_request.base.ref }}" >> $GITHUB_STEP_SUMMARY