This repository was archived by the owner on Dec 24, 2024. It is now read-only.
fixed potential infinite loop in popupRemover function..#542
Open
qw87rt wants to merge 1 commit intoTheRealJoelmatic:mainfrom
Open
fixed potential infinite loop in popupRemover function..#542qw87rt wants to merge 1 commit intoTheRealJoelmatic:mainfrom
popupRemover function..#542qw87rt wants to merge 1 commit intoTheRealJoelmatic:mainfrom
Conversation
Contributor
Author
function removeAds() { removePageAds(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
popupRemoverfunction runs every second & can cause performance issues if the process is slow and if therr are frequent popups.//can also be applied to
removeAdsfunction cuz not clearing them can lead to performance issues if many intervals are running simultaneously.isPopupBeingProcessedisPopupBeingProcessedis trueisPopupBeingProcessedto true to indicate that a popup is being processed.isPopupBeingProcessedto false.this should help mitigate potential performance issues.