Skip to content

feat: graphql headers handling, extract http create server from awili…#80

Open
kamilzielinskidev wants to merge 1 commit intomainfrom
feat/extract-app-graphql-headers
Open

feat: graphql headers handling, extract http create server from awili…#80
kamilzielinskidev wants to merge 1 commit intomainfrom
feat/extract-app-graphql-headers

Conversation

@kamilzielinskidev
Copy link
Copy Markdown

feat: graphql headers handling, extract http create server from awilix, middleware mocking enabled

@kamilzielinskidev kamilzielinskidev force-pushed the feat/extract-app-graphql-headers branch from 4195f9e to faae4dd Compare June 13, 2023 09:15
@sethii sethii requested review from rgolubowicz-tsh and removed request for rgolubowicz-tsh March 2, 2025 17:32
@sethii sethii requested a review from Copilot March 13, 2025 18:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces enhancements for handling GraphQL headers, extracts the HTTP server creation from the Awilix container, and enables middleware mocking. Key changes include adding documentation for GraphQL headers, modifying the container registration to include the application instance, and updating the server initialization in the index file.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
docs/14-graphql.md Adds documentation for GraphQL headers handling
src/container/common.ts Registers the app dependency using createApp
src/index.ts Uses http.createServer with the app instance instead of a server
src/container.ts Removes duplicate server registration from the container
src/app/app.ts Updates ApolloServer context to include the req for header support

Comment thread docs/14-graphql.md
Comment on lines +4 to +5
In order to use headers in GraphQl query, once you created GraphQL handler, you can use context param:

Copy link

Copilot AI Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in 'GraphQl': please change it to 'GraphQL' to ensure consistent capitalization.

Suggested change
In order to use headers in GraphQl query, once you created GraphQL handler, you can use context param:
In order to use headers in GraphQL query, once you created GraphQL handler, you can use context param:

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants