feat: graphql headers handling, extract http create server from awili…#80
Open
kamilzielinskidev wants to merge 1 commit intomainfrom
Open
feat: graphql headers handling, extract http create server from awili…#80kamilzielinskidev wants to merge 1 commit intomainfrom
kamilzielinskidev wants to merge 1 commit intomainfrom
Conversation
…x, middleware mocking enabled
4195f9e to
faae4dd
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces enhancements for handling GraphQL headers, extracts the HTTP server creation from the Awilix container, and enables middleware mocking. Key changes include adding documentation for GraphQL headers, modifying the container registration to include the application instance, and updating the server initialization in the index file.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| docs/14-graphql.md | Adds documentation for GraphQL headers handling |
| src/container/common.ts | Registers the app dependency using createApp |
| src/index.ts | Uses http.createServer with the app instance instead of a server |
| src/container.ts | Removes duplicate server registration from the container |
| src/app/app.ts | Updates ApolloServer context to include the req for header support |
Comment on lines
+4
to
+5
| In order to use headers in GraphQl query, once you created GraphQL handler, you can use context param: | ||
|
|
There was a problem hiding this comment.
Typo in 'GraphQl': please change it to 'GraphQL' to ensure consistent capitalization.
Suggested change
| In order to use headers in GraphQl query, once you created GraphQL handler, you can use context param: | |
| In order to use headers in GraphQL query, once you created GraphQL handler, you can use context param: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: graphql headers handling, extract http create server from awilix, middleware mocking enabled