Skip to content

refactor(netpacket): Clean up net packet code comments, struct names and duplicate code #5720

refactor(netpacket): Clean up net packet code comments, struct names and duplicate code

refactor(netpacket): Clean up net packet code comments, struct names and duplicate code #5720

Triggered via pull request February 9, 2026 22:25
Status Success
Total duration 13m 50s
Artifacts 20

ci.yml

on: pull_request
Detect File Changes
10s
Detect File Changes
Matrix: build-generalsmd-vc6
Matrix: build-generals
Matrix: build-generalsmd-win32
Matrix: replaycheck-generalsmd
Fit to window
Zoom out
Zoom in

Annotations

190 warnings
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build GeneralsMD / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6-profile+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1117
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L1041
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Tools/Autorun/GameText.cpp#L817
'int' : forcing value to bool 'true' or 'false' (performance warning)
Build GeneralsMD / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / vc6+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN' : macro redefinition
Build Generals / win32-vcpkg+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build Generals / win32-vcpkg+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/registry.cpp#L25
'WIN32_LEAN_AND_MEAN': macro redefinition
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWLib/thread.cpp#L19
'_WIN32_WINNT': macro redefinition
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWLib/thread.cpp#L19
'_WIN32_WINNT': macro redefinition
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L114
'this' : used in base member initializer list
Build Generals / vc6-debug+t+e: Core/Libraries/Source/WWVegas/WWLib/refcount.h#L99
'this' : used in base member initializer list
Build Generals / win32-vcpkg-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-vcpkg-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-vcpkg-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L163
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-vcpkg-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-vcpkg-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning

Artifacts

Produced during runtime
Name Size Digest
Generals-vc6+t+e Expired
16.1 MB
sha256:fbb29ed35939d5645f547fe6e7ba226973c48515a079237904ea65d37ee421b9
Generals-vc6-debug+t+e Expired
52 MB
sha256:872bc8b5e80880d903bfb867bce4f185fc5924647a29f4bf34a3cb38642f39cb
Generals-vc6-profile+t+e Expired
16.1 MB
sha256:1eecfa668aeb2e254f653e5c7e91756b680f7db0e673177d794f1afc91283137
Generals-win32+t+e Expired
85.4 MB
sha256:577c23c0ce830685302ace95e1765de8d0ba908422b9b5d81d7c2f428937e063
Generals-win32-debug+t+e Expired
204 MB
sha256:487cccdcc60a16df715a6e480251c45f8de97a10ca2a7fe1da04f6facc3b8cbe
Generals-win32-profile+t+e Expired
85.5 MB
sha256:6a5c0a74a8d6294c1b2551114267f32b3a6692ba8f5adb26e2d684246fae29eb
Generals-win32-vcpkg+t+e Expired
85.5 MB
sha256:a1188d58656d9dfd2ef01b3a9fc5b33696f4a9a4304fea4058366862d9322701
Generals-win32-vcpkg-debug+t+e Expired
203 MB
sha256:0b75355000750fad3e9335719f678dc50d8492ef13357f7b4cc8e19a4172d289
Generals-win32-vcpkg-profile+t+e Expired
85.3 MB
sha256:9b2aa31b8aad7eabf85e3d840f21f9f0a797096f8e20a80971b6fba7a2683e58
GeneralsMD-vc6+t+e Expired
17.1 MB
sha256:c9b39c4a7e7e74a3ab2ee60137abc9654b88fd2fa36b26931316ed740b1260e0
GeneralsMD-vc6-debug+t+e Expired
54.5 MB
sha256:b282c11a6cd5911eb50716b0334b1ba5385de9695820d7c487a6626ecf5b9754
GeneralsMD-vc6-profile+t+e Expired
17.3 MB
sha256:e00b4f759337d212f1cd41a98ae833975986f92487f7fec36f102e18c4d326aa
GeneralsMD-vc6-releaselog+t+e Expired
30.5 MB
sha256:4856a75beb534f171bad3fda22a69afd3c101facf1d212dc392404026b55badc
GeneralsMD-win32+t+e Expired
89.7 MB
sha256:be50a17d07b4d9a8d8381e030f5e9edb56eef2d94e8c412a8844bbde2ea3a8c7
GeneralsMD-win32-debug+t+e Expired
212 MB
sha256:ab2bcb414561ef994e808c39832e66205065aaf868b4e0e9d97d070907107aa4
GeneralsMD-win32-profile+t+e Expired
90.5 MB
sha256:d07a2dad197c5848ee2024876773516619e518694564b315eb199f1768b246ec
GeneralsMD-win32-vcpkg+t+e Expired
89.8 MB
sha256:98d17a20c1be987e5cbae3597da6498a02f44d41efe398541a03e02fafedecb2
GeneralsMD-win32-vcpkg-debug+t+e Expired
212 MB
sha256:be345b872bfb916e82aa0139601e26a09ec25388652e152e213cf01cc92e4b89
GeneralsMD-win32-vcpkg-profile+t+e Expired
90.2 MB
sha256:db7d5cf1f3ad86360185e218f39bd8766bc4ad3304cc0652e642071669b4c345
Replay-Debug-Log-vc6-releaselog+t+e Expired
2.8 MB
sha256:163d246fa281d79e8d9478e34bd9e38140802bdcaf2e07d730fbe8e2328dfb18