Skip to content

refactor: Add override keyword to virtual function overrides in Core code (2) #7225

refactor: Add override keyword to virtual function overrides in Core code (2)

refactor: Add override keyword to virtual function overrides in Core code (2) #7225

Triggered via pull request May 2, 2026 22:13
Status Failure
Total duration 5m 7s
Artifacts

ci.yml

on: pull_request
Detect File Changes
10s
Detect File Changes
Matrix: build-generalsmd-vc6
Matrix: build-generals
Matrix: build-generalsmd-win32
Matrix: replaycheck-generalsmd
Waiting for pending jobs
Fit to window
Zoom out
Zoom in

Annotations

35 errors and 74 warnings
Build Generals / vc6-debug+t+e
Process completed with exit code 1.
Build Generals / vc6-debug+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build GeneralsMD / vc6-debug+t+e
Process completed with exit code 1.
Build GeneralsMD / vc6-debug+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build Generals / vc6-profile+t+e
Process completed with exit code 1.
Build Generals / vc6-profile+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build Generals / vc6+t+e
Process completed with exit code 1.
Build Generals / vc6+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build Generals / vc6+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build GeneralsMD / vc6-profile+t+e
Process completed with exit code 1.
Build GeneralsMD / vc6-profile+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build GeneralsMD / vc6+t+e
Process completed with exit code 1.
Build GeneralsMD / vc6+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build GeneralsMD / vc6+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build GeneralsMD / vc6-releaselog+t+e
Process completed with exit code 1.
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build GeneralsMD / vc6-releaselog+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void __thiscall ParticlePanelDrawable::InitPanel(void)' : member function already defined or declared
Build Generals / win32-debug+t+e
Process completed with exit code 1.
Build Generals / win32-debug+t+e: Core/GameEngineDevice/Include/W3DDevice/GameClient/Module/W3DTreeDraw.h#L67
'W3DTreeDrawModuleData::getAsW3DTreeDrawModuleData': method with override specifier 'override' did not override any base class methods
Build Generals / win32-profile+t+e
Process completed with exit code 1.
Build Generals / win32-profile+t+e: Core/GameEngineDevice/Include/W3DDevice/GameClient/Module/W3DTreeDraw.h#L67
'W3DTreeDrawModuleData::getAsW3DTreeDrawModuleData': method with override specifier 'override' did not override any base class methods
Build GeneralsMD / win32-debug+t+e
Process completed with exit code 1.
Build GeneralsMD / win32-debug+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void ParticlePanelDrawable::InitPanel(void)': member function already defined or declared
Build GeneralsMD / win32-debug+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void ParticlePanelDrawable::InitPanel(void)': member function already defined or declared
Build GeneralsMD / win32-debug+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void ParticlePanelDrawable::InitPanel(void)': member function already defined or declared
Build Generals / win32+t+e
Process completed with exit code 1.
Build Generals / win32+t+e: Core/GameEngineDevice/Include/W3DDevice/GameClient/Module/W3DTreeDraw.h#L67
'W3DTreeDrawModuleData::getAsW3DTreeDrawModuleData': method with override specifier 'override' did not override any base class methods
Build GeneralsMD / win32+t+e
Process completed with exit code 1.
Build GeneralsMD / win32+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void ParticlePanelDrawable::InitPanel(void)': member function already defined or declared
Build GeneralsMD / win32+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void ParticlePanelDrawable::InitPanel(void)': member function already defined or declared
Build GeneralsMD / win32-profile+t+e
Process completed with exit code 1.
Build GeneralsMD / win32-profile+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void ParticlePanelDrawable::InitPanel(void)': member function already defined or declared
Build GeneralsMD / win32-profile+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void ParticlePanelDrawable::InitPanel(void)': member function already defined or declared
Build GeneralsMD / win32-profile+t+e: Core/Tools/ParticleEditor/ParticleTypePanels.h#L73
'void ParticlePanelDrawable::InitPanel(void)': member function already defined or declared
Detect File Changes
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build Generals / vc6-debug+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build GeneralsMD / vc6-debug+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build Generals / vc6-profile+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build Generals / vc6+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build GeneralsMD / vc6-profile+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build GeneralsMD / vc6+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build GeneralsMD / vc6-releaselog+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build Generals / win32-debug+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756, lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build Generals / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-debug+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756, lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build Generals / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32-profile+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756, lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build GeneralsMD / win32-debug+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-debug+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L165
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-debug+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-debug+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756, lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build Generals / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build Generals / win32+t+e: Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L164
operator '/': deprecated between enumerations and floating-point types
Build Generals / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build Generals / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756, lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build GeneralsMD / win32+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L165
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756, lukka/run-vcpkg@5e0cab206a5ea620130caf672fce3e4a6b5666a1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
Build GeneralsMD / win32-profile+t+e: Core/Libraries/Source/WWVegas/WWDownload/FTP.cpp#L668
'=': conversion from 'time_t' to 'int', possible loss of data
Build GeneralsMD / win32-profile+t+e: GeneralsMD/Code/Libraries/Source/WWVegas/WW3D2/ww3d.cpp#L165
operator '/': deprecated between enumerations and floating-point types
Build GeneralsMD / win32-profile+t+e
operands are different enum types 'SBServerListState' and 'SBState'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning
Build GeneralsMD / win32-profile+t+e
operands are different enum types '_GPIBool' and '_GPEnum'; use an explicit cast to silence this warning