feat(options): Implement game option to set MSAA level (#2482)

Author: Mauller

Core/GameEngine/Include/Common/OptionPreferences.h

@@ -30,6 +30,7 @@
 
 #pragma once
 
+#include "ww3d.h"
 #include "Common/UserPreferences.h"
 
 typedef UnsignedInt CursorCaptureMode;
@@ -44,8 +45,18 @@ class OptionPreferences : public UserPreferences
 	OptionPreferences();
 	virtual ~OptionPreferences() override;
 
+	enum AntiAliasingMode CPP_11(: Int)
+	{
+		AntiAliasingMode_OFF = 0,
+		AntiAliasingMode_MSAA_2X,
+		AntiAliasingMode_MSAA_4X,
+		AntiAliasingMode_MSAA_8X,
+		AntiAliasingMode_Count
+	};
+
 	Bool loadFromIniFile();
 
+	WW3D::MultiSampleModeEnum getAntiAliasing() const;
 	UnsignedInt getLANIPAddress();
 	UnsignedInt getOnlineIPAddress();
 	void setLANIPAddress(AsciiString IP);

Core/GameEngine/Source/Common/OptionPreferences.cpp

@@ -66,6 +66,19 @@ Bool OptionPreferences::loadFromIniFile()
 	return load("Options.ini");
 }
 
+WW3D::MultiSampleModeEnum OptionPreferences::getAntiAliasing() const
+{
+	OptionPreferences::const_iterator it = find("AntiAliasing");
+	if (it == end())
+		return WW3D::MULTISAMPLE_MODE_NONE;
+
+	WW3D::MultiSampleModeEnum level = (WW3D::MultiSampleModeEnum)atoi(it->second.str());
+	level = clamp(WW3D::MULTISAMPLE_MODE_NONE, level, WW3D::MULTISAMPLE_MODE_8X);
+	level = highestBit(level);
+
+	return level;
+}
+
 Int OptionPreferences::getCampaignDifficulty()
 {
 	OptionPreferences::const_iterator it = find("CampaignDifficulty");

Core/Libraries/Include/Lib/BaseType.h

@@ -58,6 +58,22 @@ inline int sign(NUM x)
 	else return 0;
 }
 
+template <typename NUM>
+inline NUM highestBit(NUM x)
+{
+	static_assert(sizeof(NUM) <= 8, "NUM must be 8 bytes or less");
+	UnsignedInt64 y = static_cast<UnsignedInt64>(x);
+
+	y |= (y >> 1);
+	y |= (y >> 2);
+	y |= (y >> 4);
+	y |= (y >> 8);
+	y |= (y >> 16);
+	y |= (y >> 32);
+
+	return static_cast<NUM>(y & ~(y >> 1));
+}
+
 // TheSuperHackers @refactor JohnsterID 24/01/2026 Add lowercase min/max templates for GameEngine layer.
 // GameEngine code typically uses BaseType.h, but may include WWVegas headers (which define min/max in always.h).
 // Header guard prevents duplicate definitions. VC6's <algorithm> lacks std::min/std::max.

Generals/Code/GameEngine/Include/Common/GlobalData.h

@@ -397,7 +397,7 @@ class GlobalData : public SubsystemInterface
 																			 units will always keep their formation. If it's <1.0, then the user must click a
 																			 smaller area within the rectangle to order the gather. */
 
-	Int m_antiAliasBoxValue;          ///< value of selected antialias from combo box in options menu
+	UnsignedInt m_antiAliasLevel;          ///< value of selected antialias level in the game options
 	Bool m_languageFilterPref;        ///< Bool if user wants to filter language
 	Bool m_loadScreenDemo;						///< Bool if true, run the loadscreen demo movie
 	Bool m_disableRender;							///< if true, no rendering!

Generals/Code/GameEngine/Source/Common/GlobalData.cpp

@@ -32,6 +32,8 @@
 // INCLUDES ///////////////////////////////////////////////////////////////////////////////////////
 #include "PreRTS.h"	// This must go first in EVERY cpp file in the GameEngine
 
+#include "ww3d.h"
+
 #include "Common/GlobalData.h"
 
 #define DEFINE_TERRAIN_LOD_NAMES
@@ -927,7 +929,7 @@ GlobalData::GlobalData()
 
 	m_standardPublicBones.clear();
 
-	m_antiAliasBoxValue = 0;
+	m_antiAliasLevel = WW3D::MultiSampleModeEnum::MULTISAMPLE_MODE_NONE;
 
 //	m_languageFilterPref = false;
 	m_languageFilterPref = true;
@@ -1204,6 +1206,8 @@ void GlobalData::parseGameDataDefinition( INI* ini )
 	TheWritableGlobalData->m_playerInfoListFontSize = optionPref.getPlayerInfoListFontSize();
 	TheWritableGlobalData->m_showMoneyPerMinute = optionPref.getShowMoneyPerMinute();
 
+	TheWritableGlobalData->m_antiAliasLevel = optionPref.getAntiAliasing();
+
 	Int val=optionPref.getGammaValue();
 	//generate a value between 0.6 and 2.0.
 	if (val < 50)

Generals/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/OptionsMenu.cpp

@@ -533,11 +533,17 @@ static void saveOptions()
 	//-------------------------------------------------------------------------------------------------
 	// antialiasing
   GadgetComboBoxGetSelectedPos(comboBoxAntiAliasing, &index);
-  if( index >= 0 && TheGlobalData->m_antiAliasBoxValue != index )
+  if( index >= 0 )
   {
-    TheWritableGlobalData->m_antiAliasBoxValue = index;
+		Int mode = WW3D::MULTISAMPLE_MODE_NONE;
+
+		// TheSuperHackers @info We are converting comboBox entry position to MultiSampleModeEnum values
+		index = clamp((int)OptionPreferences::AntiAliasingMode_OFF, index, (int)OptionPreferences::AntiAliasingMode_MSAA_8X);
+		mode = (index > 0) ? 1 << index : 0;
+
+		TheWritableGlobalData->m_antiAliasLevel = mode;
     AsciiString prefString;
-		prefString.format("%d", index);
+		prefString.format("%d", mode);
 		(*pref)["AntiAliasing"] = prefString;
   }
 
@@ -992,14 +998,6 @@ void OptionsMenuInit( WindowLayout *layout, void *userData )
 
 	Color color =  GameMakeColor(255,255,255,255);
 
-  enum AliasingMode CPP_11(: Int)
-  {
-    OFF = 0,
-    LOW,
-    HIGH,
-    NUM_ALIASING_MODES
-  };
-
 	initLabelVersion();
 
 	// Choose an IP address, then initialize the IP combo box
@@ -1103,18 +1101,32 @@ void OptionsMenuInit( WindowLayout *layout, void *userData )
 	GadgetComboBoxReset(comboBoxAntiAliasing);
 	AsciiString temp;
 	Int i=0;
-	for (; i < NUM_ALIASING_MODES; ++i)
+	for (; i < OptionPreferences::AntiAliasingMode_Count; ++i)
 	{
 		temp.format("GUI:AntiAliasing%d", i);
 		str = TheGameText->fetch( temp );
 		index = GadgetComboBoxAddEntry(comboBoxAntiAliasing, str, color);
 	}
 	Int val = atoi(selectedAliasingMode.str());
-	if( val < 0 || val > NUM_ALIASING_MODES )
+	Int pos = 0;
+
+	// TheSuperHackers @info We are converting from human readable value to comboBox entry position
+	val = highestBit(val);
+
+	if (val == WW3D::MULTISAMPLE_MODE_NONE)
+		pos = OptionPreferences::AntiAliasingMode_OFF;
+	else if (val == WW3D::MULTISAMPLE_MODE_2X)
+		pos = OptionPreferences::AntiAliasingMode_MSAA_2X;
+	else if (val == WW3D::MULTISAMPLE_MODE_4X)
+		pos = OptionPreferences::AntiAliasingMode_MSAA_4X;
+	else if (val == WW3D::MULTISAMPLE_MODE_8X)
+		pos = OptionPreferences::AntiAliasingMode_MSAA_8X;
+
+	if (val < 0 || val > WW3D::MULTISAMPLE_MODE_8X)
 	{
-		TheWritableGlobalData->m_antiAliasBoxValue = val = 0;
+		TheWritableGlobalData->m_antiAliasLevel = pos = 0;
 	}
-	GadgetComboBoxSetSelectedPos(comboBoxAntiAliasing, val);
+	GadgetComboBoxSetSelectedPos(comboBoxAntiAliasing, pos);
 
 	// get resolution from saved preferences file
 	AsciiString selectedResolution = (*pref) ["Resolution"];

Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp

@@ -821,7 +821,7 @@ void W3DDisplay::init()
 			}
 
 			// TheSuperHackers @feature Mauller 13/03/2026 Add native MSAA support, must be set before creating render device
-			WW3D::Set_MSAA_Mode(WW3D::MULTISAMPLE_MODE_NONE);
+			WW3D::Set_MSAA_Mode((WW3D::MultiSampleModeEnum)TheWritableGlobalData->m_antiAliasLevel);
 
 			renderDeviceError = WW3D::Set_Render_Device(
 				0,
@@ -831,6 +831,11 @@ void W3DDisplay::init()
 				getWindowed(),
 				true );
 
+			// TheSuperHackers @info Update the MSAA mode that was set as some GPU's may not support certain levels
+			if (renderDeviceError == WW3D_ERROR_OK) {
+				TheWritableGlobalData->m_antiAliasLevel = (UnsignedInt)WW3D::Get_MSAA_Mode();
+			}
+
 			++attempt;
 		}
 		while (attempt < 3 && renderDeviceError != WW3D_ERROR_OK);

Generals/Code/Libraries/Source/WWVegas/WW3D2/ww3d.h

@@ -73,10 +73,10 @@ class WW3D
 public:
 
 	enum MultiSampleModeEnum {
-		MULTISAMPLE_MODE_NONE,
-		MULTISAMPLE_MODE_2X,
-		MULTISAMPLE_MODE_4X,
-		MULTISAMPLE_MODE_8X
+		MULTISAMPLE_MODE_NONE = 0,
+		MULTISAMPLE_MODE_2X = 2,
+		MULTISAMPLE_MODE_4X = 4,
+		MULTISAMPLE_MODE_8X = 8
 	};
 
 	enum PrelitModeEnum {

GeneralsMD/Code/GameEngine/Include/Common/GlobalData.h

@@ -398,7 +398,7 @@ class GlobalData : public SubsystemInterface
 																			 units will always keep their formation. If it's <1.0, then the user must click a
 																			 smaller area within the rectangle to order the gather. */
 
-	Int m_antiAliasBoxValue;          ///< value of selected antialias from combo box in options menu
+	UnsignedInt m_antiAliasLevel;          ///< value of selected antialias level in the game options
 	Bool m_languageFilterPref;        ///< Bool if user wants to filter language
 	Bool m_loadScreenDemo;						///< Bool if true, run the loadscreen demo movie
 	Bool m_disableRender;							///< if true, no rendering!

GeneralsMD/Code/GameEngine/Source/Common/GlobalData.cpp

@@ -32,6 +32,8 @@
 // INCLUDES ///////////////////////////////////////////////////////////////////////////////////////
 #include "PreRTS.h"	// This must go first in EVERY cpp file in the GameEngine
 
+#include "ww3d.h"
+
 #include "Common/GlobalData.h"
 
 #define DEFINE_TERRAIN_LOD_NAMES
@@ -934,7 +936,7 @@ GlobalData::GlobalData()
 
 	m_standardPublicBones.clear();
 
-	m_antiAliasBoxValue = 0;
+	m_antiAliasLevel = WW3D::MultiSampleModeEnum::MULTISAMPLE_MODE_NONE;
 
 //	m_languageFilterPref = false;
 	m_languageFilterPref = true;
@@ -1211,6 +1213,8 @@ void GlobalData::parseGameDataDefinition( INI* ini )
 	TheWritableGlobalData->m_playerInfoListFontSize = optionPref.getPlayerInfoListFontSize();
 	TheWritableGlobalData->m_showMoneyPerMinute = optionPref.getShowMoneyPerMinute();
 
+	TheWritableGlobalData->m_antiAliasLevel = optionPref.getAntiAliasing();
+
 	Int val=optionPref.getGammaValue();
 	//generate a value between 0.6 and 2.0.
 	if (val < 50)