feat: Replace WWMath::Cos/Sin with CosTrig/SinTrig in game logic (Generals + GeneralsMD)

All game logic files that originally used global Cos()/Sin() from Trig.cpp
now use WWMath::CosTrig()/SinTrig() which preserves cosf()/sinf() behavior
without USE_DETERMINISTIC_MATH, and routes through gm_cosf()/gm_sinf()
when deterministic math is enabled.

Author: Okladnoj

Generals/Code/GameEngine/Source/Common/System/BuildAssistant.cpp

@@ -752,8 +752,8 @@ Bool BuildAssistant::isLocationClearOfObjects( const Coord3D *worldPos,
 	if (myFactoryExitWidth>0) {
 		myExitPos = *worldPos;
 		checkMyExit = true;
-		Real c = (Real)WWMath::Cos(angle);
-		Real s = (Real)WWMath::Sin(angle);
+		Real c = (Real)WWMath::CosTrig(angle);
+		Real s = (Real)WWMath::SinTrig(angle);
 		Real offset = build->getTemplateGeometryInfo().getMajorRadius() + myFactoryExitWidth/2.0f;
 		myExitPos.x += c*offset;
 		myExitPos.y += s*offset;
@@ -787,8 +787,8 @@ Bool BuildAssistant::isLocationClearOfObjects( const Coord3D *worldPos,
 		if (themFactoryExitWidth>0) {
 			hisExitPos = *them->getPosition();
 			checkHisExit = true;
-			Real c = (Real)WWMath::Cos(them->getOrientation());
-			Real s = (Real)WWMath::Sin(them->getOrientation());
+			Real c = (Real)WWMath::CosTrig(them->getOrientation());
+			Real s = (Real)WWMath::SinTrig(them->getOrientation());
 			Real offset = them->getGeometryInfo().getMajorRadius() + themFactoryExitWidth/2.0f;
 			hisExitPos.x += c*offset;
 			hisExitPos.y += s*offset;

Generals/Code/GameEngine/Source/Common/System/Geometry.cpp

@@ -279,8 +279,8 @@ void GeometryInfo::get2DBounds(const Coord3D& geomCenter, Real angle, Region2D&
 
 		case GEOMETRY_BOX:
 		{
-			Real c = (Real)WWMath::Cos(angle);
-			Real s = (Real)WWMath::Sin(angle);
+			Real c = (Real)WWMath::CosTrig(angle);
+			Real s = (Real)WWMath::SinTrig(angle);
 			Real exc = m_majorRadius*c;
 			Real eyc = m_minorRadius*c;
 			Real exs = m_majorRadius*s;
@@ -398,8 +398,8 @@ void GeometryInfo::makeRandomOffsetWithinFootprint(Coord3D& pt) const
 #else
 			Real radius = GameLogicRandomValueReal(0.0f, m_boundingCircleRadius);
 			Real angle = GameLogicRandomValueReal(-PI, PI);
-			pt.x = radius * WWMath::Cos(angle);
-			pt.y = radius * WWMath::Sin(angle);
+			pt.x = radius * WWMath::CosTrig(angle);
+			pt.y = radius * WWMath::SinTrig(angle);
 			pt.z = 0.0f;
 #endif
 			break;

Generals/Code/GameEngine/Source/Common/Thing/Thing.cpp

@@ -109,8 +109,8 @@ const Coord3D* Thing::getUnitDirectionVector2D() const
 	if (!(m_cacheFlags & VALID_DIRVECTOR))
 	{
 		Real angle = getOrientation();
-		m_cachedDirVector.x = WWMath::Cos( angle );
-		m_cachedDirVector.y = WWMath::Sin( angle );
+		m_cachedDirVector.x = WWMath::CosTrig( angle );
+		m_cachedDirVector.y = WWMath::SinTrig( angle );
 		m_cachedDirVector.z = 0;
 		m_cacheFlags |= VALID_DIRVECTOR;
 	}
@@ -229,8 +229,8 @@ void Thing::setOrientation( Real angle )
 		z.y = 0.0f;
 		z.z = 1.0f;
 
-		u.x = WWMath::Cos(angle);
-		u.y = WWMath::Sin(angle);
+		u.x = WWMath::CosTrig(angle);
+		u.y = WWMath::SinTrig(angle);
 		u.z = 0.0f;
 
 		y.crossProduct( &z, &u, &y );

Generals/Code/GameEngine/Source/GameLogic/AI/AIGroup.cpp

@@ -1839,8 +1839,8 @@ void getHelicopterOffset( Coord3D& posOut, Int idx )
   }
 
   Coord3D tempCtr = posOut;
-  posOut.x = tempCtr.x + (WWMath::Sin(angle) * radius);
-  posOut.y = tempCtr.y + (WWMath::Cos(angle) * radius);
+  posOut.x = tempCtr.x + (WWMath::SinTrig(angle) * radius);
+  posOut.y = tempCtr.y + (WWMath::CosTrig(angle) * radius);
 
 }
 

Generals/Code/GameEngine/Source/GameLogic/AI/AISkirmishPlayer.cpp

@@ -663,8 +663,8 @@ void AISkirmishPlayer::buildAIBaseDefenseStructure(const AsciiString &thingName,
 		}
 
 		if (angle > PI/3) break;
-		Real s = WWMath::Sin(angle);
-		Real c = WWMath::Cos(angle);
+		Real s = WWMath::SinTrig(angle);
+		Real c = WWMath::CosTrig(angle);
 
 // TheSuperHackers @info helmutbuhler 21/04/2025 This debug mutates the code to become CRC incompatible
 #if defined(RTS_DEBUG) || !RETAIL_COMPATIBLE_CRC
@@ -1029,8 +1029,8 @@ void AISkirmishPlayer::adjustBuildList(BuildListInfo *list)
 
 	angle += 3*PI/4;
 
-	Real s = WWMath::Sin(angle);
-	Real c = WWMath::Cos(angle);
+	Real s = WWMath::SinTrig(angle);
+	Real c = WWMath::CosTrig(angle);
 
 	cur = list;
 	while (cur) {

Generals/Code/GameEngine/Source/GameLogic/AI/AIStates.cpp

@@ -604,8 +604,8 @@ StateReturnType AIRappelState::update()
 														bldg->getGeometryInfo().getBoundingCircleRadius());
 					Real angle = GameLogicRandomValueReal( PI, 2*PI );//Downish.
 					Coord3D startPosition = *bldg->getPosition();
-					startPosition.x += offset * WWMath::Cos( angle );
-					startPosition.y += offset * WWMath::Sin( angle );
+					startPosition.x += offset * WWMath::CosTrig( angle );
+					startPosition.y += offset * WWMath::SinTrig( angle );
 					startPosition.z = TheTerrainLogic->getGroundHeight( startPosition.x, startPosition.y );
 
 					obj->setPosition( &startPosition );
@@ -3804,8 +3804,8 @@ void AIFollowWaypointPathState::computeGoal(Bool useGroupOffsets)
 		dy = dest.y - m_priorWaypoint->getLocation()->y;
 		angle = WWMath::Atan2(dy, dx);
 		Real deltaAngle = angle - m_angle;
-		Real s = WWMath::Sin(deltaAngle);
-		Real c = WWMath::Cos(deltaAngle);
+		Real s = WWMath::SinTrig(deltaAngle);
+		Real c = WWMath::CosTrig(deltaAngle);
 		Real x = m_groupOffset.x * c - m_groupOffset.y * s;
 		Real y = m_groupOffset.y * c + m_groupOffset.x * s;
 		m_groupOffset.x = x;

Generals/Code/GameEngine/Source/GameLogic/Map/TerrainLogic.cpp

@@ -339,8 +339,8 @@ Bridge::Bridge(Object *bridgeObj)
 	Real halfsizeY = bridgeObj->getGeometryInfo().getMinorRadius();
 	m_bridgeInfo.bridgeWidth = 2*halfsizeY;
 
-	Real c = (Real)WWMath::Cos(angle);
-	Real s = (Real)WWMath::Sin(angle);
+	Real c = (Real)WWMath::CosTrig(angle);
+	Real s = (Real)WWMath::SinTrig(angle);
 
 	m_bridgeInfo.fromLeft.set(pos->x-halfsizeX*c-halfsizeY*s, pos->y + halfsizeY*c - halfsizeX*s, pos->z);
 	m_bridgeInfo.toLeft.set(pos->x+halfsizeX*c-halfsizeY*s, pos->y + halfsizeY*c + halfsizeX*s, pos->z);
@@ -1471,8 +1471,8 @@ void makeAlignToNormalMatrix( Real angle, const Coord3D& pos, const Coord3D& nor
 		that WWMath::Atan2(xvec.y, xvec.x) == angle. So we must construct
 		the matrix carefully to ensure this!
 	*/
-	x.x = WWMath::Cos( angle );
-	x.y = WWMath::Sin( angle );
+	x.x = WWMath::CosTrig( angle );
+	x.y = WWMath::SinTrig( angle );
 	x.z = 0.0f;
 //x.normalize();	-- redundant; is normalized by definition
 
@@ -2652,8 +2652,8 @@ void TerrainLogic::flattenTerrain(Object *obj)
 			Real halfsizeY = obj->getGeometryInfo().getMinorRadius();
 
 
-			Real c = (Real)WWMath::Cos(angle);
-			Real s = (Real)WWMath::Sin(angle);
+			Real c = (Real)WWMath::CosTrig(angle);
+			Real s = (Real)WWMath::SinTrig(angle);
 
 			Vector3 topLeft(pos->x-halfsizeX*c-halfsizeY*s, pos->y + halfsizeY*c - halfsizeX*s, 0);
 			Vector3 topRight(pos->x+halfsizeX*c-halfsizeY*s, pos->y + halfsizeY*c + halfsizeX*s, 0);

Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/DumbProjectileBehavior.cpp

@@ -225,10 +225,10 @@ static Bool calcTrajectory(
 		// calc the horiz-speed & time for each.
 		// note that time can only be negative for 90<angle<270, and since we
 		// ruled those out above, we're gold.
-		sinPitches[0] = WWMath::Sin(pitches[0]);
-		sinPitches[1] = WWMath::Sin(pitches[1]);
-		cosPitches[0] = WWMath::Cos(pitches[0]);
-		cosPitches[1] = WWMath::Cos(pitches[1]);
+		sinPitches[0] = WWMath::SinTrig(pitches[0]);
+		sinPitches[1] = WWMath::SinTrig(pitches[1]);
+		cosPitches[0] = WWMath::CosTrig(pitches[0]);
+		cosPitches[1] = WWMath::CosTrig(pitches[1]);
 		Real t0 = (horizDist / (velocity * cosPitches[0]));
 		Real t1 = (horizDist / (velocity * cosPitches[1]));
 

Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/GenerateMinefieldBehavior.cpp

@@ -304,8 +304,8 @@ void GenerateMinefieldBehavior::placeMinesAroundCircle(const Coord3D& pos, Real
 	for (Real angle = 0; angle < angleLim; angle += angleInc)
 	{
 		Coord3D pt;
-		pt.x = pos.x + radius * WWMath::Cos(angle);
-		pt.y = pos.y + radius * WWMath::Sin(angle);
+		pt.x = pos.x + radius * WWMath::CosTrig(angle);
+		pt.y = pos.y + radius * WWMath::SinTrig(angle);
 		pt.z = TheTerrainLogic->getGroundHeight( pt.x, pt.y );
 		offsetBySmallRandomAmount(pt, mineJitter);
 		placeMineAt(pt, mineTemplate, team, obj);

Generals/Code/GameEngine/Source/GameLogic/Object/Behavior/ParkingPlaceBehavior.cpp

@@ -327,8 +327,8 @@ Bool ParkingPlaceBehavior::reserveSpace(ObjectID id, Real parkingOffset, Parking
 		info->parkingSpace = d->m_parkInHangars ? ppi->m_hangarStart : ppi->m_location;
 		if (parkingOffset != 0.0f)
 		{
-			info->parkingSpace.x += parkingOffset * WWMath::Cos(ppi->m_orientation);
-			info->parkingSpace.y += parkingOffset * WWMath::Sin(ppi->m_orientation);
+			info->parkingSpace.x += parkingOffset * WWMath::CosTrig(ppi->m_orientation);
+			info->parkingSpace.y += parkingOffset * WWMath::SinTrig(ppi->m_orientation);
 		}
 		info->runwayPrep = ppi->m_prep;
 		info->parkingOrientation = d->m_parkInHangars ? ppi->m_hangarStartOrient : ppi->m_orientation;