Skip to content

Commit acb68e3

Browse files
committed
Optimized code.
1 parent 1e43fa1 commit acb68e3

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

  • GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus

GeneralsMD/Code/GameEngine/Source/GameClient/GUI/GUICallbacks/Menus/ReplayMenu.cpp

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -295,14 +295,6 @@ void PopulateReplayFileListbox(GameWindow *listbox)
295295
const UnicodeString displayTimeBuffer = getUnicodeTimeBuffer(header.timeVal);
296296
const UnicodeString displayDateBuffer = getUnicodeDateBuffer(header.timeVal);
297297

298-
UnicodeString displayDateTimeBuffer;
299-
if (columns == 4)
300-
{
301-
// TheSuperHackers @info Caball009 09/02/2025 The original replay window menu has only four columns.
302-
// Concatenate time and date for a single column if there aren't two dedicated columns for time and date.
303-
displayDateTimeBuffer.format(L"%s %s", displayTimeBuffer.str(), displayDateBuffer.str());
304-
}
305-
306298
// version (no-op)
307299

308300
// map
@@ -364,6 +356,11 @@ void PopulateReplayFileListbox(GameWindow *listbox)
364356
DEBUG_ASSERTCRASH(insertionIndex >= 0, ("Expects valid index"));
365357
if (columns == 4)
366358
{
359+
// TheSuperHackers @info Caball009 09/02/2025 The original replay window menu has only four columns.
360+
// Concatenate time and date for a single column if there aren't two dedicated columns for time and date.
361+
UnicodeString displayDateTimeBuffer;
362+
displayDateTimeBuffer.format(L"%s %s", displayTimeBuffer.str(), displayDateBuffer.str());
363+
367364
GadgetListBoxAddEntryText(listbox, displayDateTimeBuffer, color, insertionIndex, 1);
368365
GadgetListBoxAddEntryText(listbox, header.versionString, color, insertionIndex, 2);
369366
GadgetListBoxAddEntryText(listbox, mapStr, mapColor, insertionIndex, 3);

0 commit comments

Comments
 (0)