bugfix(audio): Restore retail compatibility after optimization change in AudioManager::addAudioEvent (#2132)

Author: Caball009

Core/GameEngine/Source/Common/Audio/GameAudio.cpp

@@ -443,10 +443,14 @@ AudioHandle AudioManager::addAudioEvent(const AudioEventRTS *eventToAdd)
 			break;
 	}
 
-	if (!eventToAdd->getUninterruptable()) {
-		if (!shouldPlayLocally(eventToAdd)) {
-			return AHSV_NotForLocal;
-		}
+	// TheSuperHackers @info Scripted audio events are logical, i.e. synchronized across clients.
+	// This early return cannot be taken for such audio events as it skips code that changes the logical game seed values.
+	const Bool logicalAudio = eventToAdd->getIsLogicalAudio();
+	const Bool notForLocal = !eventToAdd->getUninterruptable() && !shouldPlayLocally(eventToAdd);
+
+	if (!logicalAudio && notForLocal)
+	{
+		return AHSV_NotForLocal;
 	}
 
 	AudioEventRTS *audioEvent = MSGNEW("AudioEventRTS") AudioEventRTS(*eventToAdd);		// poolify
@@ -463,6 +467,12 @@ AudioHandle AudioManager::addAudioEvent(const AudioEventRTS *eventToAdd)
 		}
 	}
 
+	if (notForLocal)
+	{
+		releaseAudioEventRTS(audioEvent);
+		return AHSV_NotForLocal;
+	}
+
 	// cull muted audio
 	if (audioEvent->getVolume() < m_audioSettings->m_minVolume) {
 #ifdef INTENSIVE_AUDIO_DEBUG