Skip to content

Commit d3e99d9

Browse files
committed
Changed area selection enum names.
1 parent bc50caa commit d3e99d9

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

GeneralsMD/Code/GameEngine/Include/Common/MessageStream.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,6 @@ class GameMessage : public MemoryPoolObject
224224
MSG_META_SELECT_HERO, ///< selects player's hero character, if exists...
225225
MSG_META_SELECT_ALL, ///< selects all units across screen
226226
MSG_META_SELECT_ALL_AIRCRAFT, ///< selects all air units just like select all
227-
MSG_META_AREA_SELECTION, ///< rectangular selection area (pixelRegion)
228227
MSG_META_SCATTER, ///< selected units scatter
229228
MSG_META_STOP, ///< selected units stop
230229
MSG_META_DEPLOY, ///< selected units 'deploy'
@@ -446,7 +445,8 @@ class GameMessage : public MemoryPoolObject
446445
MSG_MOUSEOVER_LOCATION_HINT, ///< (location) The cursor is not over a drawable, but is here.
447446
MSG_VALID_GUICOMMAND_HINT, ///< posted when the gui command is valid if the user clicked to execute it.
448447
MSG_INVALID_GUICOMMAND_HINT, ///< posted when the gui command is not valid if the user were to click to attempt to execute it.
449-
MSG_AREA_SELECTION_HINT, ///< (pixelRegion) rectangular selection area under construction, not confirmed
448+
MSG_BEGIN_AREA_SELECTION_HINT, ///< rectangular selection area (pixelRegion) under construction, not confirmed
449+
MSG_END_AREA_SELECTION_HINT, ///< rectangular selection area (pixelRegion) finish construction
450450

451451
//Command hints
452452
MSG_DO_ATTACK_OBJECT_HINT, ///< (victim objectID) If clicked, an attack would be ordered, "Current Selection" is assumed

GeneralsMD/Code/GameEngine/Source/Common/MessageStream.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,6 @@ const char *GameMessage::getCommandTypeAsString(GameMessage::Type t)
331331
CASE_LABEL(MSG_META_SELECT_HERO)
332332
CASE_LABEL(MSG_META_SELECT_ALL)
333333
CASE_LABEL(MSG_META_SELECT_ALL_AIRCRAFT)
334-
CASE_LABEL(MSG_META_AREA_SELECTION)
335334
CASE_LABEL(MSG_META_SCATTER)
336335
CASE_LABEL(MSG_META_STOP)
337336
CASE_LABEL(MSG_META_DEPLOY)
@@ -544,7 +543,8 @@ const char *GameMessage::getCommandTypeAsString(GameMessage::Type t)
544543
CASE_LABEL(MSG_MOUSEOVER_LOCATION_HINT)
545544
CASE_LABEL(MSG_VALID_GUICOMMAND_HINT)
546545
CASE_LABEL(MSG_INVALID_GUICOMMAND_HINT)
547-
CASE_LABEL(MSG_AREA_SELECTION_HINT)
546+
CASE_LABEL(MSG_BEGIN_AREA_SELECTION_HINT)
547+
CASE_LABEL(MSG_END_AREA_SELECTION_HINT)
548548
CASE_LABEL(MSG_DO_ATTACK_OBJECT_HINT)
549549
CASE_LABEL(MSG_DO_ATTACK_OBJECT_AFTER_MOVING_HINT)
550550
CASE_LABEL(MSG_DO_FORCE_ATTACK_OBJECT_HINT)

GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/HintSpy.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,14 +97,14 @@ GameMessageDisposition HintSpyTranslator::translateGameMessage(const GameMessage
9797
break;
9898

9999
//-----------------------------------------------------------------------------
100-
case GameMessage::MSG_AREA_SELECTION_HINT:
100+
case GameMessage::MSG_BEGIN_AREA_SELECTION_HINT:
101101
TheInGameUI->beginAreaSelectHint( msg );
102102
break;
103103

104104
//-----------------------------------------------------------------------------
105-
// An AREA_SELECTION_HINT is always followed by an AREA_SELECTION, so
105+
// A BEGIN_AREA_SELECTION_HINT is always followed by an END_AREA_SELECTION_HINT, so
106106
// watch for it to stop hinting.
107-
case GameMessage::MSG_META_AREA_SELECTION:
107+
case GameMessage::MSG_END_AREA_SELECTION_HINT:
108108
TheInGameUI->endAreaSelectHint( msg );
109109
break;
110110

GeneralsMD/Code/GameEngine/Source/GameClient/MessageStream/SelectionXlat.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -427,7 +427,7 @@ GameMessageDisposition SelectionTranslator::translateGameMessage(const GameMessa
427427
if (m_dragSelecting)
428428
{
429429
// insert area selection "hint" message into stream
430-
GameMessage *hintMsg = TheMessageStream->appendMessage( GameMessage::MSG_AREA_SELECTION_HINT );
430+
GameMessage *hintMsg = TheMessageStream->appendMessage( GameMessage::MSG_BEGIN_AREA_SELECTION_HINT );
431431

432432
// build rectangular region defined by the drag selection
433433
IRegion2D pixelRegion;
@@ -517,7 +517,7 @@ GameMessageDisposition SelectionTranslator::translateGameMessage(const GameMessa
517517
TheInGameUI->selectMatchingAcrossScreen();
518518

519519
// emit "picked" message
520-
GameMessage *pickMsg = TheMessageStream->appendMessage( GameMessage::MSG_META_AREA_SELECTION );
520+
GameMessage *pickMsg = TheMessageStream->appendMessage( GameMessage::MSG_END_AREA_SELECTION_HINT );
521521
pickMsg->appendDrawableIDArgument( picked->getID() ); /// note we are putting in a drawable id
522522

523523
if (TheInGameUI->isInPreferSelectionMode() && !listOfSelectedDrawables.empty()) {
@@ -932,7 +932,7 @@ GameMessageDisposition SelectionTranslator::translateGameMessage(const GameMessa
932932
TheInGameUI->endAreaSelectHint(nullptr);
933933

934934
// insert area selection message into stream
935-
GameMessage *dragMsg = TheMessageStream->appendMessage( GameMessage::MSG_META_AREA_SELECTION );
935+
GameMessage *dragMsg = TheMessageStream->appendMessage( GameMessage::MSG_END_AREA_SELECTION_HINT );
936936

937937
IRegion2D selectionRegion;
938938
buildRegion( &m_selectFeedbackAnchor, &msg->getArgument(0)->pixel, &selectionRegion );

0 commit comments

Comments
 (0)